https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43460
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #34 from David Cook <[email protected]> --- (In reply to Pedro Amorim (ammopt) from comment #29) > Hey Andrew, thanks for passing along Mike's question: > 37762 didn't change how API calls return data in general. JSON requests and > responses are untouched. The conversion only applies to application/xml > traffic, which Koha's core REST API didn't support before 37762. > What broke were plugin routes that handle XML themselves (like the NCIP > example here). With this patchset, a plugin that returns its own XML works > without any change, and a plugin route that accepts an XML request body must > add x-koha-raw-payload to its spec to receive the original XML. Without it, > the controller receives a JSON conversion of the body instead. I haven't reviewed the code but... wouldn't it have made more sense to make this XML to JSON conversion opt-in at the controller level? Requiring x-koha-raw-payload at the request end... makes no sense to me. We're making everything bend around the ILL? Shouldn't ILL be the exception to the rule and not the other way around? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
