https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43560
--- Comment #6 from Andrew Fuerste-Henry <[email protected]> --- Created attachment 211086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211086&action=edit Bug 43560: (QA follow-up) Require a value for --since, --interval and --progress The conversion declared --since, --interval and --progress with an optional value (:s, :i), where Getopt::Long had them requiring one (=s, =i). Passed without a value they used to stop the script with "requires an argument". With :s, a bare --since gave an empty string: it counts as defined, so --incremental skipped its 24 hour default, but it is false, so no date limit was added to the statistics query. --use-stats --incremental --since would then add every historical checkout on top of the existing total issues counts. A bare --interval or --progress was caught by the new callbacks, but with a confusing ("") or ("0") value in the message. Declare all three with a required value again. Test plan: 1. update_totalissues.pl --use-stats --incremental --test -v --since => Option since requires an argument 2. update_totalissues.pl --use-stats --interval => Option interval requires an argument 3. update_totalissues.pl --use-stats --progress => Option progress requires an argument 4. update_totalissues.pl --use-stats --test --interval 30d --progress 10 => Runs as before Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Andrew Fuerste Henry <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
