https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature --- Comment #166 from Katrin Fischer <[email protected]> --- This feature goes a lot deeper than I had thought on first glance and I like it! I especially like the concept of it, since it's MARC record independent (which has always been a blocker for us for making use of EasyAnalytics) and only requires one actual item record. It also covers the use case exactly, where the parts are treated more equally instead of strictly hierarchically. When testing a big feature, there are always new ideas sprouting on how to improve things even more - But I feel this covers all the most important bits and pieces to make this a well-rounded and useful addition to Koha. 1) OK - QA TESTS AND UNIT TESTS - are passing. 2) CODE REVIEW a) Check for system preference in code (question) It looks like we don't always check for the system preference. I am not sure if this is an issue, but wanted to raise it for consideration. b) Templates (question) Surprised by the non-standard HTML tags here: +[% IF Koha.Preference('EnableBoundWithItems') %] + <bound-with-modal biblionumber="[% biblionumber | html %]" can-manage="[% CAN_user_editcatalogue_manage_item_biblio_links ? 1 : 0 | html %]"></bound-with-modal> +[% END %] + c) Authorised value ITEM_BIBLIO_LINK_TYPE (no blocker) I am a bit confused by this. It looks like the AV is currently not used and if that is a thought for a future enhancement, maybe moving analytics? The code comment says it's for handling display, but I don't see any reference to it in the templates. Maybe missing something? If for later use, I think it would have been cleaner to add it later, but it's not a blocker for me. c) OK - XSLT Both OPAC and staff interface are updated. Bit silly that this field has no label, but that's MARC for you. d) OK (provided follow-up) Database updates Needs to be moved to the new format - fixed in my QA follow-up! + $dbh->do( + q{ + INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) + VALUES ('EnableBoundWithItems', '0', NULL, 'Enable the bound-with feature to allow linking one item to multiple bibliographic records', 'YesNo') + } d) OK- Translatability No issues spotted. Also a big plus on capitalization and use of terminology. 3) TESTING a) Configuration (not blocker) The system preference reads: Note that a full search engine reindex is required after enabling this feature and creating links, so that availability appears on all linked records. Is the index really required after turning on the feature if you haven't added any links yet (which you can't before enabling the feature?) b) OK - Detail and results pages I am impressed by the fact that searching for the barcode turns up all my 3 items in search. That's awesome. c) OK - Managing links I quite like the way the links are created and displayed on the records. It's quite intuitive to use. (for later) The modal could be a bit bigger to accommodate a longer list of search results a little better. d) OK - Holds - OK - holds queue and holds to pull - OK - false item won't trigger holds - OK - right item will trigger hold Tried several combinations of holds on the different records on item and record level. e) Small stuff and questions (for later) Display: There are some more pages where displaying the information about the bound with would be nice: * Staff: Holds list in patron account * Staff: Holds list in catalog/record detail * List of checkouts in staff/OPAC Notices: I wonder if we can print the "right" title in the notices. Might need a little extra work/mark-up. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
