https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43981

--- Comment #6 from Nick Clemens (kidclamp) <[email protected]> ---
Created attachment 211144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211144&action=edit
Bug 43981: (QA follow-up) Use DBI sql_types constants for numeric columns

This patch replaces the hard-coded ODBC type codes with the named
constants exported by DBI's :sql_types tag, uses a hash lookup instead
of a chain of comparisons, and skips columns whose type is undefined
to avoid 'uninitialized value' warnings.

No behaviour change is expected.

Test plan:
1. Apply patches
2. Create a SQL report with:
     SELECT 1, '1', '01', 'one'
3. Run the report and download the result as ODS
4. Verify only the first column receives a float type
5. Verify the leading zero of the third column is retained

Signed-off-by: Nick Clemens <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Nick Clemens <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to