https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44030
--- Comment #4 from David Nind <[email protected]> --- Created attachment 211166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211166&action=edit Bug 44030: Let FineNoRenewalsBlockAutoRenew allow automatic renewals again Since bug 23415 CanBookBeRenewed refuses any renewal when the patron owes more than FineNoRenewals (too_much_owing). For automatic renewals the choice belongs to FineNoRenewalsBlockAutoRenew: _CanBookBeAutoRenewed already returns auto_too_much_owing when it is set to block. When it is set to allow, the cron reached the general check and was refused anyway, so "allow" did nothing. The general fine check now leaves a cron renewal of an auto-renewing checkout to that preference. Renewals by staff, the OPAC or self checkout are checked exactly as before. Test plan: 1. FineNoRenewals = 10, FineNoRenewalsBlockAutoRenew = allow. 2. Check out an item with "Automatic renewal" to a patron whose autorenew_checkouts is on, and set the circulation rule "No automatic renewal before" so that it is due for renewal. 3. Add a 15.00 manual invoice to the patron. 4. perl misc/cronjobs/automatic_renewals.pl -c -v: not renewed (too_much_owing). 5. Apply the patch, repeat 4: the checkout is renewed. 6. Set FineNoRenewalsBlockAutoRenew = block, repeat 4 with another such checkout: not renewed (auto_too_much_owing). 7. Renewing the item from the staff interface is still refused for the fine. 8. prove t/db_dependent/Circulation.t Sponsored-by: Koha Solutions Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
