https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |k Status|Passed QA |Failed QA --- Comment #12 from Pedro Amorim (ammopt) <[email protected]> --- Hi Baptiste, the patch swaps the resubmit prompt for an "invoice does not exist" error in the exact scenario it's meant to fix. 'Cancel receipt' on parcel.pl is a POST with the invoiceid only in the form body, so after cancelling, the page URL is just /cgi-bin/koha/acqui/parcel.pl. The new opener.location.replace(origin + pathname + search) loads that bare URL, and parcel.pl can't find an invoice. To reproduce in KTD, with the patch applied: 1) Create a destination basket for 'My Vendor', name it 'Dest' and click 'Save': http://localhost:8081/cgi-bin/koha/acqui/basketheader.pl?booksellerid=1&op=add_form 2) Add an order to the source basket 'My Basket': http://localhost:8081/cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1 Enter any title, pick fund 'Main fund', vendor price '10' and click 'Save' 3) Close the source basket. On its page click 'Close basket' and confirm: http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1 4) Start a receipt for 'My Vendor': http://localhost:8081/cgi-bin/koha/acqui/parcels.pl?booksellerid=1 Enter 'Vendor invoice' 'test40575' and click 'Next' 5) In 'Pending orders' click 'Receive' on the order, then click 'Confirm' 6) Back on the receipt page, in 'Already received' click 'Cancel receipt' on the order 7) Note the URL is now http://localhost:8081/cgi-bin/koha/acqui/parcel.pl with no invoiceid 8) In 'Pending orders' click 'Transfer' on the order. A new window opens. In it, search 'My Vendor' and click 'Search', click 'Choose' on 'My Vendor', then 'Choose' on basket 'Dest' 9) Confirm the new window closes and the receipt page reloads with "The invoice referenced by this invoiceid does not exist." instead of showing invoice 'test40575' -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
