http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |[email protected]

--- Comment #2 from M. Tompsett <[email protected]> ---
Actually, I was thinking about this annoying problem too, and that's not how I
was thinking of solving it.

Around line 774 the $pki_field is defined and set as part of an if statement,
but because it can be short-circuited, the variable is sometimes not defined.

I would suggest that the solution is to put:
my $pki_field = C4::Context->preference('AllowPKIAuth') || q{};
before the if statement.
AND
change the if statement to be
... || $pki_field ne 'None' ...

This way $pki_field is defined, and string comparisons shouldn't generate
silent errors.

I'm switching this to in discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to