http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |[email protected] --- Comment #62 from M. de Rooy <[email protected]> --- QA Comment: Works as described. Code looks good to me. Passed QA Just a few side-notes: Can we prevent constructions like [% IF ( Branches.GetURL( ITEM_RESULT.homebranch ) ) %] <a href="[% Branches.GetURL( ITEM_RESULT.homebranch ) %]">[% Branches.GetName( ITEM_RESULT.homebranch ) %]</a> making repeated calls to same function? The code for showing shelf loc also relies heavily on having 1) the shelf loc obviously, 2) having auth val LOC on that field and 3) in that particular framework. I had something in location, but it would not show up until I realized that the biblio was in another framework :) GetURL includes a statement: return encode( 'UTF-8', $b->{'branchurl'} ); It works, but (outside the scope of this report) it would be even better if we should not need them at that spot. Referring further to encoding problems/discussions.. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
