http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105

Owen Leonard <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <[email protected]> ---
This patch adds "<span id="topics-span"> Topics</span>" whereas other patches
in this batch do something like this:

<span id="facet-Itemtypes"> Item types </span>

I think the "facet-XXX" pattern is better since it is more descriptive. It's
redundant to give an id to your span which includes the word "span."

Thanks for the patch--I hope you can submit a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to