http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589
M. de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.r...@rijksmuseum.nl --- Comment #23 from M. de Rooy <m.de.r...@rijksmuseum.nl> --- QA Comment: Code looks good to me. Works as advertised. No complaints from qa tools. Passed QA Just some smaller points (no blockers imo): 1) No unit tests. Adding these makes the chance of a push considerably larger :) 2) The names of the prefs are not completely explanatory on itself. The name does not give a clue that this pref has to do with unhiding items for some patron categories. 3) The dbrev for install and upgrade contains empty string for the systempreferences fields options and type. This works, but imo it should be better (more consistent) to set type to Free and options to NULL. (Please have a look at other prefs.) 4) To make it easier for the user, a followup could update the description of OpacHiddenItems making the user aware that these two new prefs make it possible to fine-tune its behavior. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/