http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #9 from mathieu saby <[email protected]> ---
(In reply to Jonathan Druart from comment #8)
> I am a little bit disconcerted.
> The aqbasketgroup.tt is really dirty and it is not easy to do something in
> it.

=> so true. it's horrible. And very hard to understand without reindenting...

> But this patch is not really clear:
> 1/ I don't know if to add a lot of simple comment is useful (in the pl file).

It was usefull for me, to understand how the file was structured. But I can
suppress comments if they are unneeded.

> 4/ There is a mix between new code and indentation fixes (use the -w option
> for git show).

For me reindentation were logical, because I add a new condition in the
template (l. 147:    [% IF (closedbg) %]   ), so I felt free to reindent

For the other points, I cannot answer quickly, and must watch it closely.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to