http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #35 from Katrin Fischer <[email protected]> --- Hi Jonathan, I am sorry, but the patch does no longer apply. Some questions I had from looking at the code/patches: 1) Can we ensure that patrons can't access discharge notices from other patrons by guessing the file name? I know this would be a rewrite, but keep wondering if this could be done dynamically and without storing files. Like have a flag that the user is allowed to download a discharge notice with date x and then generate the pdf file dynamically. 2) The email send to the library is not translatable. Instead of sending an email to the library, it could show up on the dashboard. 3) Can you provide unit tests for the new module and routines please? 4) I think this bit will have to be changed for the new handling of debarments/restrictions: + # (this is quite ugly, but this is how borrowers seems to be permanently debarred) + # FIXME: Perl strings are not translatable atm, so comment is written in english + C4::Members::DebarMember($borrowernumber, '9999-12-31', "Discharge generated by $librarianname on $date"); 5) Question: Which cronjobs are needed for this? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
