http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23234|0 |1 is obsolete| | Attachment #23235|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <[email protected]> --- Created attachment 23236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23236&action=edit [SIGNED OFF] Bug 11096: force XML syntax for Zconn and remove MARC::File::USMARC everywhere. This patch makes Koha <-> Zebra exchange speak XML instead of the current 'USMARC'. For that, it changes some bits in - C4::Context->Zconn - C4::Context-_new_Zconn Zebra's 'element' variable is set to "marcxml" to match our zebra config files. References to MARC::File::USMARC::decode are substituted for calls to the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit 'UTF-8' encoding for the task. This patch also removes calls to the unsafe ZOOM::Record->render()[2] method. Due to this last change the code for building facets was rewritten. And for performance on the facets creation I pushed higher version dependencies for MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string). - The FindDuplicates function was MARCXML-ized too. - Unit tests have been moved to expect MARCXML from Zebra as well. TODO: relevance still uses USMARC. Need advise on that. References to MARC::File::USMARC where replaced for the corresponding MARC::File::XML counterpart from AuthoritiesMarc.pm. - Authorities search should work as usual. - Set dontmerge to see AuthoritiesMarc::merge still works. Regards To+ [1] As a side effect some encoding problems got fixed in facets and record details. http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode() [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render() Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer <[email protected]> Testing notes on second patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
