http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963
--- Comment #25 from Bernardo Gonzalez Kriegel <[email protected]> --- Thank's Katrin, In Discussion is the rigth state! I was working on this, now I will share what I found 1) Following David on comment #14 I did this query (only default and simple fw loaded) select tagfield, tagsubfield, hidden, group_concat(frameworkcode order by frameworkcode) as fws from marc_subfield_structure group by concat(tagfield,tagsubfield,hidden) having fws <> ',AR,BKS,CF,IR,KT,SER,SR,VR'; The result show where fw differs on hidden value between them. 2) The rearranged results, can be seen on attached file hidden-differences.txt (N for NULL value) There are 635 lines on that file, most are from subfields present on default but not in simple fw 3) As we are looking for customizations, I'll discard all new subfields, they will be copied anyway. Results on attached file hidden-differences-no-new.txt Now they are "only" 296 lines. But they are still a lot of updates to do on a copied fw, not practical 4) What I saw is that many subfields on simple fw have identical value on hidden field, but not on default fw. PROPOSAL: when all simple fw agrees on a hidden value, we set default with that value That will leave us with "real" customizations 5) With that proposal, results on attached file hidden-real.txt There are only 39 lines now. And only hidden values are -6, -1 and 0 Just to remember: -6 => OPAC Intranet !Editor !Collapsed -1 => OPAC Intranet Editor Collapsed 0 => OPAC Intranet Editor !Collapsed If we change -1 for 0 (if it's on editor, why collapsed?), we can take out a few more lines, but that's enough 6) Well, if there is a clear customization plan on hidden-real.txt, it's difficult for me to see it (except a few subfields) For me is more like a pseudo-random distribution of 3 values on 39 subfields out of 3959 on 9 fw :-) If we are going to provide simple fw with a meaning. I expect directives like: On serials and ..., hide 020 and ... On books and ..., hide 022 and ... etc. In that way, if we have a default fw with some sort of visibility on all fields/subs, we can hide at field level on simple fw. Writing all update lines needed to implement hidden-real "as is" is doable, and I already did it (without my proposal, around ~300 lines), so if I have no more comments on how to do this right, I will upload it and switch to need signoff. Regards, B -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
