http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319
--- Comment #3 from Kyle M Hall <[email protected]> --- As a POC, it looks pretty good to me! The only suggestion I would have would be not keep the export for read_field, and modify that sub to check for a value in the subfield value. That is, instead of having read, read_field, and read_subfield, keep all the code in read_field and just do an if/then/else. That way the exported name is still read_field, and thus doesn't change the API. It's entirely possible for SimpleMARC to be used in custom scripts, so adding to the API is fine, but removing/renaming api subs should be avoided. I know that such an occurence is unlikely at this point, but even in the future it will confuse users to have update_field, copy_field, move_field, read, and delete. It just breaks the naming convention. The other option would be to remove "_field" from all the subroutines. I have no problem with either choice. Let's just keep the convention standardized! Other than that, it looks good to me! Kyle (In reply to Jonathan Druart from comment #2) > Kyle and Galen, I really would like to have your opinion on this patch > please. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
