http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735
Tomás Cohen Arazi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23010|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <[email protected]> --- Created attachment 23700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23700&action=edit Bug 10735 - prevent script aborting if backupdir undefined Older versions of Koha didn't have <backupdir>...</backupdir> defined in koha-conf.xml. The koha-dump script is aware of this, and checks to see if it's there. However, if it's not, xmlstarlet returns a non-0 error code which causes the script to abort due to running under set -e. Test plan: * Remove backupdir from koha-conf.xml * Run koha-dump, notice that it doesn't do backups * Apply patch * Run koha-dump again, notice that it does do backups Signed-off-by: Tomas Cohen Arazi <[email protected]> The fallback method works as described. It might be made more robust like checking for dir existence (thinking of older instances upgrades). But it certaintly belongs to another bug report. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
