http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #37 from Katrin Fischer <[email protected]> --- Comment on attachment 23527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23527 Bug 9303 [2/2] - relative's checkouts in the opac Review of attachment 23527: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9303&attachment=23527) ----------------------------------------------------------------- No major findings - mostly noting a few things: I think maybe it would be better to separate the Schema and kohastructure/updatedatabase changes into 2 separate patches. Also adding a new PK to issues and old_issues could have been a separate bug/patch. ::: C4/Reserves.pm @@ +270,5 @@ > + $sth->execute($reserve_id); > + $res = $sth->fetchrow_hashref(); > + } > + > + carp("No hold for for reserve_id $reserve_id") unless $res; Hm, this change seems unrelated to the bug description? ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +1168,5 @@ > + <option value="1">Yes</option> > + [% END %] > + </select> > + <div class="hint">Allow linked patron accounts to view this > patron's checkouts from the OPAC</div> > + </li> This is different to how we handle the other privacy seetings in that we don't allow staff to change those for a patron. I see why staff will want to change that setting for a parent requesting it, but at the same time it bothers me a bit. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ +1,3 @@ > [% USE Koha %] > [% USE KohaDates %] > +[% USE EncodeUTF8 %] The only script using this so far is renew.pl - can you explain a bit? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
