http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114

--- Comment #4 from M. de Rooy <[email protected]> ---
(In reply to M. de Rooy from comment #3)
> Tomas: Thank you for your patch. I have a comment however :) You use binmode
> on STDOUT in the module, but you print to a file handle. So that should not
> be enough. I would suggest to replace the binmode by adding the encoding to
> the output file handles. Note that I also had a wide character warning in my
> log on admin/import_export_framework. You probably need to touch code there
> as well?
> I tested with a Chinese character; that went well (export and re-import).
> Since you actually leave it to Perl to decide the encoding, Perl made the
> right choice here. But with some Latin characters only, export and re-import
> made them disappear..
> 
> Failed QA

Some confusion: The binmode is not in the module, but printing to the file
handle is. So please correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to