http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237

--- Comment #12 from Jonathan Druart <[email protected]> ---
(In reply to M. de Rooy from comment #10)
> (In reply to M. Tompsett from comment #8)
> > Two things I noticed when I tested.
> > 1) The order of the system preference text box was changed. I don't think
> > that is problem, but felt I should note that.
> 
> Just looking at the patch, I do not understand your remark.

Before the patch, it was <input> pref description
Now it is: pref description <input>
I thought it is better but maybe i am wrong. Feel free to change the order if
you disagree.

> I agree that it should be blank. In the code I see a split on this pref
> without further testing. (May not harm, but correcting it is better.)
> Although you formally could say that it is actually outside report scope, I
> would like to ask Jonathan to just handle this tiny 'bug' within the same db
> revision (in the same update statement). No need to touch the same code in
> two reports.

Done!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to