http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254
M. Tompsett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22956|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <[email protected]> --- Created attachment 24525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24525&action=edit [SIGNED OFF] Bug 11254 - breeding search must normalize ISBN When importing records, the ISBN is normalized and stored into database (see C4::Breeding::ImportBreeding). But when searching with ISBN into reservoir, it is not normalized (see C4::Breeding::BreedingSearch). So search does not match. This patch adds the normalisation to breeding search. Also replaces call private method _isbn_cleanup by GetNormalizedISBN, the correct public method. Also allows the breeding search on ISBN with hyphens. This is intended to fix only reservoir searches. Revised Test plan ----------------- 1) Back up DB 2) Save copy of attached example somewhere findable 2) Home -> Tools -> Stage MARC records for import 3) Click Browse and select the example MARC file 4) Click Upload file 5) Tweak as desired then click Stage for import 6) Click Manage staged records 7) Click Import this batch into the catalog 8) Home -> Cataloging 9) In the Cataloging search text box type 978-0-691-14289-0 and click Submit -- ISBN13 with hypens not found in reservoir 10) In the Cataloging search text box type 9780691142890 and click Submit -- ISBN13 without hypens not found in reservoir 11) In the Cataloging search text box type 0-691-14289-0 and click Submit -- ISBN10 with hypens not found in reservoir 12) In the Cataloging search text box type 0691142890 and click Submit -- ISBN10 without hypens found in reservoir 13) Apply patch 14) Repeat steps 9-12, this time it is always found! :) Signed-off-by: Mark Tompsett <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
