http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352
Jacek Ablewicz <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Jacek Ablewicz <[email protected]> --- (In reply to Chris Cormack from comment #1) > Is it deleting ones it shouldn't? Yes; I can replicate this as well. It will delete (or move to trash) ones it shouldn't. Evidently there is a problem with how given parameter borrower_dateexpiry is (not) being properly converted when passed from step2 to step3 in tools/cleanborrowers.pl - somehow this parameter value gets mangled in the process. In step2 this script does: $filterdate1 = format_date_in_iso( $params->{'filterdate1'} ); $filterdate2 = format_date_in_iso( $params->{'filterdate2'} ); $borrower_dateexpiry = format_date_in_iso( $params->{'borrower_dateexpiry'} ); ... $template->param( filterdate1 => format_date($filterdate1), filterdate2 => format_date($filterdate2), borrower_dateexpiry => $borrower_dateexpiry, Note there is no format_date() call on $borrower_dateexpiry in line #100.. Changing line 100 to borrower_dateexpiry => format_date($borrower_dateexpiry), seems to fix this issue (at least for me). But: my comprehension of date handling in Koha is very far from perfect; I can't really guarantee this would be a proper fix. I guess the exact outcome may also depend on 'dateformat' setting in I18N/L10N preferences (we use dd/mm/yyyy; for yyyy-mm-dd unpatched script may actually work seemingly fine!). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
