http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733

            Bug ID: 11733
           Summary: "gist" system preference inconsistently treated as
                    single-value or multi-value
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

The "gist" system preference, which specifies tax rates available for use in
various places in acquisitions, lets the user specify multiple values separated
by pipe symbols.  The first value is taken to be the default tax rate to apply.

However, there are some places in the code where it effectively assumes that
gist contains only one value:

acqui/basketgroup.pl:        if ($bookseller->{invoiceincgst} && !
$bookseller->{listincgst} && ( $bookseller->{gstrate} // C4::Co
acqui/basketgroup.pl:            my $gst = $bookseller->{gstrate} //
C4::Context->preference("gist");
acqui/basketgroup.pl:    my $pdf = printpdf($basketgroup, $bookseller,
$baskets, \%orders, $bookseller->{gstrate} // C4::Context->
acqui/invoice.pl:my $gist = $bookseller->{gstrate} //
C4::Context->preference("gist") // 0;
acqui/parcel.pl:my $gst = $bookseller->{gstrate} //
C4::Context->preference("gist") // 0;

and other places where it assumes (correctly) that it can have multiple values:

acqui/neworderempty.pl:}, split( '\|', C4::Context->preference("gist") );
acqui/supplier.pl:    }, split( '\|', C4::Context->preference("gist") );

Routines should be written for fetching either the list of tax rates or the
default tax rate as needed.

See also bug 11680.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to