http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427
Rafal Kopaczka <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #219 from Rafal Kopaczka <[email protected]> --- I've looked quickly at this patch, got 2 issues (or not, correct me if I'm wrong): 1/ In part 4 patch, there is reference to js file that don't exist in repository, next parts also don't contain this file. Bug-6427-Part-04.patch:93:+<script type="text/javascript" src="[% interface %]/[% theme %]/en/js/strings.js"></script> 2/ In part 3, function format_without_symbol don't handle properly, national currencies without leading symbol (eg PLN). It truncate always first character even if it's a number. return substr( $self->format( $amount, FMT_SYMBOL ), 1 ); We can't assume that format always return symbol before number. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
