http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864

--- Comment #3 from M. Tompsett <[email protected]> ---
Comment on attachment 25714
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25714
Add the OpacBelowLoginBox preference.

Review of attachment 25714:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6864&attachment=25714)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +7825,5 @@
>  }
>  
> +$DBversion = "XXX";
> +if ( CheckVersion($DBversion) ) {
> +    $dbh->do("INSERT INTO `systempreferences` 
> (variable,value,options,explanation,type) VALUES ('OpacBelowLoginBox','', 
> '30|10','Texte à afficher en dessous de la boite de login','Textarea');");

I believe the text should be in English.

::: koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt
@@ +87,5 @@
>  <input type="submit" value="Log In" class="submit" />
>  <div id="nologininstructions">
> +    [% IF ( opacbelowloginbox ) %]
> +        [% opacbelowloginbox %]
> +        [% IF PatronSelfRegistration && 
> PatronSelfRegistrationDefaultCategory %]<span 
> id="registrationinstructions"><a 
> href="/cgi-bin/koha/opac-memberentry.pl">Register here</a></span>[% END %]

Kind of strange to have the self-registration stuff in both IF and ELSE
clauses. Put it after the IF/ELSE.

::: koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt
@@ +62,5 @@
>  
>        </fieldset></fieldset>
>       </form>
> +    <br style="clear:both" />
> +    <div>

div's should have id's or classes or some way of being able to affect them via
Javascript, in my opinion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to