http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558
Galen Charlton <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #54 from Galen Charlton <[email protected]> --- Close, but there is a serious issue left: a regression on bug 2060. In particular, this patch regresses on the ability to properly display authority record batches. Instead of linking to the authority details page for imported records, for example, it links to the *bibliographic* details page. Sorting by citation for authority batches is also broken -- GetImportRecordsRange() is asked to sort by title when it should be sorting by authorized_heading. By the way, it would be preferable to me if GetImportRecordsRange() did not rely on dbh_quote_identifier() to sanitize the sorting column, which at present is passed directly from a CGI parameter. It should instead set $order_by to one of a known set of values, similar to how you deal with $order_by_direction. A much more minor issue: tools/batch_records_ajax.pl asserts that it's both GPL2 and GPL3+. Please squash your QA follow-ups (but not Owen's) when you resubmit. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
