http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Galen Charlton <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Galen Charlton <[email protected]> --- I think it is stretching just a bit too far to have 1 out of six patches being signed off resulting in an overall bug status of signed off. Also, follow-up 5 doesn't seem to apply. More to the point, the collections.colbranchcode column is too narrow. It should be varchar(10) and a FK linking to the branches table. Failing QA on that basis; I further request that you change the status to needs signoff, not signed off, when you submit a follow-up. Also, given the age of the original code and the fact that it has not be in general use, there's even more call to write unit tests. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
