http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #3 from M. Tompsett <[email protected]> --- Comment on attachment 26589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26589 Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved Review of attachment 26589: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11999&attachment=26589) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ +609,4 @@ > my $title = $$biblio{title}; > > # Check if the biblio can be reserved > + my ($canbookbereserved) = CanBookBeReserved($borrowernumber, > $biblionumber); The change in interface that passes back reasons is lost, when you don't include a variable for it. Also, it makes this look like a pointless variable. I suppose it's just hard to read and not really incorrect. @@ +686,5 @@ > return { code => 'RecordNotFound' } if $$item{biblionumber} ne > $$biblio{biblionumber}; > > # Check for item disponibility > + my ($canitembereserved) = C4::Reserves::CanItemBeReserved( > $borrowernumber, $itemnumber ); > + my ($canbookbereserved) = C4::Reserves::CanBookBeReserved( > $borrowernumber, $biblionumber ); Why is there a C4::Reserves::CanBookBeReserved call here, but a CanBookBeReserved in the earlier code? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
