http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868
Galen Charlton <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Galen Charlton <[email protected]> --- The second patch is weird -- it doesn't just remove CancelReserveFromId, it has the effect of *changing* CancelReserve: - it adds a return that no callers actually check - more importantly, it removes the code to insert the old hold into old_reserves, which is a pretty clear regression. I'm marking failed QA on this basis. I strongly encourage starting the patch over from scratch; a patch that adds a routine that then gets immediately removed by its follow-up is confusing, at the very least, and risks whatever merge reconciliation failure happened here. In particular, I don't see that it is necessary to touch C4/Reserves.pm at all to implement this change; if there are concerns about CancelReserve's behavior, that should go into a separate bug. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
