http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481
--- Comment #11 from Jonathan Druart <[email protected]> --- Comment on attachment 26685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26685 Bug 9481 (QA follow-up) - Add unit test for GetItemCharges in C4::Overdues. Review of attachment 26685: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9481&attachment=26685) ----------------------------------------------------------------- ::: t/db_dependent/Overdues.t @@ +69,5 @@ > + $sth->execute(@$loop); > +} > + > +ok(GetItemCharges($itemnumber, $borrowernumber) == 348.25, "GetItemCharges > returns all outstanding charges for item"); > + What is 348.25? Please make this more readable. @@ +71,5 @@ > + > +ok(GetItemCharges($itemnumber, $borrowernumber) == 348.25, "GetItemCharges > returns all outstanding charges for item"); > + > +my $anotheritemnumber = $itemnumber + 999999; > +my $anotherborrowernumber = $borrowernumber + 999999; These numbers could exist in a big DB and the test will fail. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
