http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072
--- Comment #16 from Jonathan Druart <[email protected]> --- Comment on attachment 27130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27130 [SIGNED-OFF] Bug 12072: Add date format dd.mm.yyyy. Review of attachment 27130: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12072&attachment=27130) ----------------------------------------------------------------- ::: C4/Dates.pm @@ +40,4 @@ > > sub _prefformat { > unless ( defined $prefformat ) { > + $prefformat = C4::Context->preference('dateformat') || 'us'; I disagree with setting a default value for this pref. It must exist in DB. ::: C4/Templates.pm @@ +112,4 @@ > $vars->{opacsmallimage} = C4::Context->preference('opacsmallimage'); > $vars->{opaclayoutstylesheet} = > C4::Context->preference('opaclayoutstylesheet'); > + $vars->{dateformatstyle} = C4::Dates->new()->formatstr(); 1/ Prefer to use Koha::DateUtils instead of C4::Dates. 2/ C4::Dates is not used in C4::Templates. 3/ Prefer to sent variable to template in C4::Auth (common way to do). 4/ Very good initiative! ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt @@ +283,4 @@ > return; > } > var date_due = new Date($('#duedatespec').datepicker('getDate')); > + date_due.setHours(23, 59); Hum... why this change? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
