http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |[email protected] --- Comment #30 from Katrin Fischer <[email protected]> --- I looked at this code a while ago, but had to stop testing in the midst of it. Now the patches no longer apply as we have changed a lot of other things in this area in the last few days, so I can't test. >From memory: the removal of destBranch didn't seem quite right. Also the described behaviour worried me: "- Verify the hold list: The item is waiting for B and C has a priority 2 - Delete the hold for B - Now you can see the item is not waiting for C. He has not been notified neither. If you apply all patches from this bug, at the next step, the item is marked as waiting for C and C has been notified when the hold for B has been deleted." If I read this correctly, the item would be set to waiting automatically and trigger the notice to the patron. I am not sure if this is a good idea. I think setting the waiting status should always require a check in. This way the correct slip can be printed and mistakes are much less likely. - Like sending the book back to the shelf, when it should remain at the circulation desk. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
