http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673
--- Comment #57 from Jonathan Druart <[email protected]> --- (In reply to Katrin Fischer from comment #42) > 1) I wonder about the names of the new permissions. > I think a limited edition would be something different - maybe we > can get a native speaker's opinion on this? Done. > 2) Please include all .sql permission files, so new installations won't > miss them. You can check with xt/permissions.t Done. > 3) Fix sequence of system preferences Done. > 4) If we are going to rewrite this bit of code, it would be good to > remove the use of CGI::scrolling_list (bug 766): > + $subfield_data{marc_value} =CGI::scrolling_list(@scrparam); It will be done when bug 766 will be pushed. > 5) System preference description could be more clear. It should note that > the FA framework is excluded from the permission. Also it could include > a hint that the example is for UNIMARC and also include a MARC21 example > to avoid confusion. For us developers it's clear that we use different > item fields for both flavours, but not so much for librarians I guess. Done. > 6) I have my doubts about the superlibrarian checks you used: > && $limitededition->{'superlibrarian'} eq 1); > +$limitededition = 0 if ($limitededition != 0 && > $limitededition->{'superlibrarian'} eq 1); > We now have a specific method to check those: > C4::Context::IsSuperLibrarian() Done. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
