http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622
--- Comment #5 from Galen Charlton <[email protected]> --- Comment on attachment 24754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24754 Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal Review of attachment 24754: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11622&attachment=24754) ----------------------------------------------------------------- ::: opac/opac-account-pay-paypal-return.pl @@ +1,5 @@ > +#!/usr/bin/perl > + > +# Copyright Katipo Communications 2002 > +# Copyright Biblibre 2007,2010 > +# This seems unlikely. @@ +18,5 @@ > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + > +use strict; > +use warnings; Modern::Perl @@ +20,5 @@ > + > +use strict; > +use warnings; > +use utf8; > + I see no non-ASCII characters in the source. ::: opac/opac-account-pay.pl @@ +1,4 @@ > +#!/usr/bin/perl > + > +# Copyright Katipo Communications 2002 > +# Copyright Biblibre 2007,2010 This seems unlikely. @@ +18,5 @@ > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + > +use strict; > +use warnings; Modern::Perl @@ +19,5 @@ > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + > +use strict; > +use warnings; > +use utf8; I see no non-ASCII characters in the source. @@ +65,5 @@ > + > + my $opac_base_url = C4::Context->preference('OPACBaseURL'); > + > + my $return_url = > + URI->new( "http://"; This should be checking whether the OPAC is using SSL. @@ +94,5 @@ > + 'PAYMENTREQUEST_0_PAYMENTACTION' => 'Sale', > + 'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' => 'InstantPaymentOnly', > + 'PAYMENTREQUEST_0_DESC' => > + C4::Context->preference('PayPalChargeDescription'), > + }; It seems like using Business::PayPal::API might offer some protection against API changes. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
