http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
Martin Renvoize <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Martin Renvoize <[email protected]> --- Passing QA with the following comments: 1. This patch is a good start to tidying up the cslt handling in koha, good work. 2. I find this patch also fixes the https issues in bug 12172 3. I believe this enforces a more strict behaviour when using remote stylesheets. (I found that pre patch, you could use the directory path in the Utils import within your remote sheet and it would be relative to root on the local system. However, after the patch, I had to also host the Utils file remotely and link import that one in the remote stylesheet) 4. It would be 'nice' to have some warning added to enable tracking through errors when a sheets fails to load. however, handling here is preferable to existing behaviour of falling back to an unhandled error in the browser. 5. I'm not sure I agree with how the sysprefs have been implemented, but this patch is consistent with current behaviour. [default - uses default stylesheets, path - is relative to root of filesystem, URL - uses remote stylesheets] I'd prefer to see the path be relative to the root of the htdocs (and thereby allowing a simple Alias in the virtual host to point to the stylesheet. Anywho, I don't see any reasons to fail. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
