http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061
--- Comment #23 from Bernardo Gonzalez Kriegel <[email protected]> --- (In reply to Jonathan Druart from comment #20) > Comment on attachment 28645 [details] [review] > Bug 12061 - tmpl_process3.pl - Include/exclude file by name > > Review of attachment 28645 [details] [review]: > ----------------------------------------------------------------- > > ::: misc/translator/tmpl_process3.pl > @@ +134,5 @@ > > > > sub listfiles { > > + my($dir, $type, $action) = @_; > > + my $filenames = join ('|', @filenames); > > + my $nofilenames = join ('|', @nofilenames); > > Don't you think it is better to pass filenames and nofilenames in parameter > rather than using global vars? May be. What we can pass is a reference, so we are using them (glob vars) anyway. My thinking was that we pass \@filenames, later use @$filenames, why not directly use @filenames? If you think it's more clear to pass them explicitly, no problem from me, i'll rewrite that. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
