http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266

Marc Véron <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12295

--- Comment #7 from Marc Véron <[email protected]> ---
Hi Zeno,

After the latest pull (3.17.00.007, including Bug 12295), the z39.50 search
window pops up as expected.

However I have a question:

Original code:
    var alreadySelected = $.cookie('auth_to_merge');
    if (alreadySelected !== null) {
    (...)
    }

if-statement in Patch for Bug 12295:
    if (alreadySelected !== undefined)

if-statement in Patch for Bug 12266:
    if ((typeof alreadySelected !== 'undefined') && (alreadySelected !== null))

Question:
For some reason there was a test for null in the original code. 
Is it ever possible that $.cookie('auth_to_merge') results to null? If yes, I
suppose that it should be tested as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to