http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Katrin Fischer <[email protected]> --- Starting with QA script, unit tests and code review: 1) QA script: FAIL t/db_dependent/Acquisition.t FAIL valid "my" variable $order2 masks earlier declaration in same scope "my" variable $error masks earlier declaration in same scope OK critic OK pod OK forbidden patterns FAIL acqui/cancelorder.pl OK valid FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 8) OK pod OK critic FAIL acqui/addorder.pl OK valid FAIL forbidden patterns forbidden pattern: tab char (line 126) OK pod OK critic 2) Code review a) Not sure here, but should the copyright year be updated? +# Copyright 2011 BibLibre SARL b) Capitalization + <input type="submit" class="approve" value="Yes, Cancel (Y)" accesskey="y" /> + <input type="submit" class="deny" value="No, Don't Cancel (N)" accesskey="n" onclick="window.location='[% referrer %]';return false;" /> Could you please fix in a follow up? I will then try to come back to this as soon as possible. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
