http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212
--- Comment #59 from Katrin Fischer <[email protected]> --- Hi Jonathan, thx for providing new patches, this is a fun feature! Starting with a code review: 1) QA script I had this error before I ran the database update: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt OK forbidden patterns FAIL valid_template DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha.columns_settings' doesn't exist at /home/katrin/kohaclone/C4/Utils/DataTables/ColumnsSettings.pm line 34 After the database update QA script was ok. 2) Copyright - update? +# Copyright BibLibre 2013 3) Add new library to About page? jquery.dataTables.colvis.js 4) Capitalization Is Hidden by default Now onto testing: 5) Configuration page Nice accordeon :) Changes save correctly. a) After saving a new configuration, it would be nice if the section you worked in remained open, instead of it jumping back to the first - Acquisitions. b) I am not sure why currency is displayed twice in different font size? 6) Currencies page The table showed according to what I had configured. Changes made with the options on the page were remembered during my session. Table shows as normal with Javascript deactivated. a) The options to toggle/hide could be positioned a bit closer to the table, maybe we could even use an icon later? Just something we could try to improve a bit more. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
