http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877
--- Comment #18 from Kyle M Hall <[email protected]> --- Comment on attachment 29406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29406 Bug 10877 - Add "Order Record" processing Review of attachment 29406: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10877&attachment=29406) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +967,3 @@ > =cut > > sub GetImportBatchRangeDesc { Agreed. There are no unit tests for this. I think it would be extremely difficult to unit test. However, the additions I've made to it are close to trivial. ::: acqui/addorderiso2709.pl @@ +270,5 @@ > my @serials = $input->param('serial'); > my @ind_tag = $input->param('ind_tag'); > my @indicator = $input->param('indicator'); > + > + if ($is_order) { This is so we can pre-set the items to a notforloan value of 'ordered', and to preset the home and holding fields to the current branch, as well as pre-set the itemtype. @@ +295,5 @@ > + GetMarcFromKohaField('items.itype'); > + push( @tags, $itype_field ); > + push( @subfields, $itype_subfield ); > + push( @field_values, $infos->{itype} ); > + warn "ITYPE: " . $infos->{itype}; Will fix! @@ +359,1 @@ > While I agree, I wanted to make as few changes as possible to that subroutine. @@ +450,5 @@ > item_action => $item_action > ); > batch_info($template, $batch); > + > + return \@list; I just thought it sensible to have the sub return something. Considering no caller of the sub takes in the return value, I expect it will be compiled away. I can remove this if you think it prudent. ::: installer/data/mysql/updatedatabase.pl @@ +8565,5 @@ > + $dbh->do("ALTER TABLE import_batches ADD is_order BOOLEAN NOT NULL > DEFAULT '0' AFTER comments"); > + print "Upgrade to $DBversion done (Bug 10877 - Add 'Order Record' > processing)\n"; > + SetVersion ($DBversion); > + > +} Will fix! ::: koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc @@ +18,4 @@ > <li><a href="/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=[% > booksellerid %]&basketno=[% basketno %]">From an external source</a></li> > <li><a href="/cgi-bin/koha/acqui/addorderiso2709.pl?booksellerid=[% > booksellerid %]&basketno=[% basketno %]"> From a staged file</a></li> > [% IF ( CAN_user_circulate ) %]<li><a > href="/cgi-bin/koha/circ/reserveratios.pl?booksellerid=[% booksellerid > %]&basketno=[% basketno %]">From titles with highest hold > ratios</a></li>[% END %] > + <li><a href="/cgi-bin/koha/acqui/addorderiso2709.pl?booksellerid=[% > booksellerid %]&basketno=[% basketno %]&is_order=1"> From a staged > order file</a></li> Will fix! ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ +145,5 @@ > + $("#checkAll").click(); > + > + $("#all_budget_id").hide(); > + $('label[for="all_budget_id"]').hide(); > + [% END %] I believe this is causing issues do to the fact that this patch targeted an earlier version of bug 7180. I will update the patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
