http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961
--- Comment #5 from Katrin Fischer <[email protected]> --- Comment on attachment 26516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26516 [SIGNED-OFF] Add a "Z39.50 search" button to the authority creation and modification pages. Review of attachment 26516: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11961&attachment=26516) ----------------------------------------------------------------- Hi Eric, I have used the splinter review to add my comments. I like this addition, please provide a follow-up. ::: authorities/authorities.pl @@ +344,4 @@ > return int(rand(1000000)); > } > > +=item GetMandatoryFieldZ3950 Hard coding the fields in many places is a problem - please refactor so that it is using the same method as GuessAuthTypeCode. It also needs to be MARC agnostic (support UNIMARC) and have unit tests. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt @@ +201,4 @@ > <br />Go to page : <input id="goto_page" name="goto_page" value="[% > current_page %]" size="4" /><input type="submit" name="changepage_goto" > onclick="return validate_goto_page();" value="Go" /> > </form> > > +<p><form method="get" > action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" > name="authid" value="[% authid %]" /><input type="submit" value="Try Another > Search"/></form></p> Please fix the capitalization here (I know it was wrong before, but this is a good moment to do it). @@ +214,4 @@ > </div> > [% END %] > <div class="dialog message">Nothing found.</div> > + <p><form method="get" > action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" > name="authid" value="[% authid %]" /><input type="submit" value="Try Another > Search"/></form></p> Also here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
