This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.20.x has been updated
via 630faec194d5341f33e95704163d8022d5fe1519 (commit)
via b2689594e36ef9d17b6efe1070ed5960f96dc479 (commit)
via 740ba172eb96c4dbfc5ec4c553d04c43f9c5136f (commit)
from 7fd329a520e6123ff61a74efd675370d7877b24e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 630faec194d5341f33e95704163d8022d5fe1519
Author: Marcel de Rooy <[email protected]>
Date: Mon May 25 11:32:51 2015 +0200
Bug 14267: How active is active?
git grep on function active in additem.tt:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:function
active(n
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:active([%
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:function a
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:
t/Cache.t: unless ( $cache->is_cache_active() && defined $cache );
t/Cache.t: unless ( $cache->is_cache_active() );
Conclusion: active in additem seems to be quite inactive.
Test plan:
Add, edit or delete items and verify that you did not miss active :)
NOTE: The active function has a loop which is always run.
Inside that loop 'ong' would always be defined as some number
concatenated with XX.
Both sides of the if/else reference document.getElementById(ong),
but there is only one occurence of XX in the file: the concatenation!
Similarly, the 'link' logic does not correspond to any of the
id= or name= strings in the file.
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
is the only file with "id=\"link" that matches the logic.
This is likely a cut-and-paste remnant made useless by datatable
upgrades
and HTML/CSS class changes.
Signed-off-by: Mark Tompsett <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Tomas Cohen Arazi <[email protected]>
(cherry picked from commit f327ebe540103905ccc4d36dcc5275b1b5644be5)
Signed-off-by: Chris Cormack <[email protected]>
commit b2689594e36ef9d17b6efe1070ed5960f96dc479
Author: Katrin Fischer <[email protected]>
Date: Mon May 25 12:13:08 2015 +0200
Bug 14269: OPAC: Some template improvements for the full serial history page
- Fix filter labels:
Library : -> Library:
Subscription : -> Subscription:
- Make '(All)' entry in filter pull downs translatable
- Show branch name instead of branchcode in table and filter
To test:
- Verify changes as described above
- Verify filters still work as expected
Followed test plan. Works as expected.
Signed-off-by: Marc Véron <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Tomas Cohen Arazi <[email protected]>
(cherry picked from commit 5bbea3ea2ca08e7d1b785cdfb90524bb29f553ac)
Signed-off-by: Chris Cormack <[email protected]>
commit 740ba172eb96c4dbfc5ec4c553d04c43f9c5136f
Author: Marc Véron <[email protected]>
Date: Tue Jun 2 09:54:15 2015 +0200
Bug 14313: OPAC - Adding a comment makes result browser disappear
To reproduce:
- Allow commenting in OPAC (Syspref reviewson)
- Log in to OPAC
- Do a search with many results
- Click on a biblio in result list
- Verify that you can browse the results in detail view ("Browse results")
- Repeat teh search above
- Click on the same biblio as above
- Add a comment (Tab "Comments")
- Close commenting window
- Click on "Next" in result browser
Result: The next biblio is displayed, but result browser has disappeared.
To test:
- Apply patch
- Try to reproduce issue above, verify that result browser does no longer
disappear
AMended to remove whitespace chars. / MV
Signed-off-by: Bernardo Gonzalez Kriegel <[email protected]>
Bug & solution checked, works well. No koha-qa errors
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Tomas Cohen Arazi <[email protected]>
(cherry picked from commit 22c5c4b468b3584ed8bf45039c1494e969f2d66b)
Signed-off-by: Chris Cormack <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 7 +++++--
.../prog/en/modules/cataloguing/additem.tt | 16 ----------------
.../bootstrap/en/modules/opac-full-serial-issues.tt | 15 ++++++++-------
3 files changed, 13 insertions(+), 25 deletions(-)
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
