This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 687a7e22b6c630c3bbc06e1845854514f6fea5b0 (commit)
via c4f388f64966f2202e9f3e3c16dad5cef3dbe0ac (commit)
from 113adf68e56b6233b44a2b7a9b5dc60f6c4de0b7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 687a7e22b6c630c3bbc06e1845854514f6fea5b0
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date: Tue Jun 7 11:48:46 2016 +0100
Bug 16441: Fix Letters.t
These tests were wrong, but the package variable used to cache the
letters hid the problem.
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <k...@bywatersolutions.com>
commit c4f388f64966f2202e9f3e3c16dad5cef3dbe0ac
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date: Wed May 4 19:43:43 2016 +0100
Bug 16441: Do not use a package variable to cache C4::Letters::getletter
C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to
remove it.
It won't be a big deal to hit the DBMS to get a valid letter when
needed.
No test plan here, just confirm that the changes make sense.
Signed-off-by: Srdjan <srd...@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Confirm that performance loss is just a millisecond or so per
subsequent call of getletter.
Signed-off-by: Kyle M Hall <k...@bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 11 -----------
t/db_dependent/Letters.t | 4 ++--
2 files changed, 2 insertions(+), 13 deletions(-)
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
