This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 8323db303dd6d1c486574e7750ad58df2c25c744 (commit)
via 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757 (commit)
via d019f86f671771a36006f8847712317e0337c02f (commit)
from 15506a7569145cf566aab28e1b7639be56058a26 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 8323db303dd6d1c486574e7750ad58df2c25c744
Author: Jonathan Druart <[email protected]>
Date: Wed Aug 10 12:29:57 2016 +0100
Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping
This subroutine was only used once in GetItemsForInventory.
It can be replaced with a quite simple search on AV join on
authorised_value_categories and marc_subfield_structures tables.
Note that the "interface" parameter was always set to "staff" and was
useless.
Test plan:
Play with the inventory and confirm that the AV descriptions are
correctly displayed.
The tests in t/db_dependent/Items/GetItemsForInventory.t cover this
change and should still pass.
Signed-off-by: Claire Gravely <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Kyle M Hall <[email protected]>
commit 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757
Author: Jonathan Druart <[email protected]>
Date: Wed Oct 12 13:48:09 2016 +0100
Bug 17250: Do not retrieve marc subfield structure when the authorised
value is not defined
GetAuthValCode did not return anything if the authorised_value column
was not defined. Our new calls to Koha::MarcSubfieldStructures->search
should behave the same
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Kyle M Hall <[email protected]>
commit d019f86f671771a36006f8847712317e0337c02f
Author: Jonathan Druart <[email protected]>
Date: Wed Aug 10 13:35:13 2016 +0100
Bug 17250 - Koha::AuthorisedValues - Remove GetAuthValCode
The subroutine C4::Koha::GetAuthValCode returned the authorised value
category for a given kohafield.
This can be acchieve easily using a new
Koha::AuthorisedValues->search_by_koha_field
method which will mimic search_by_marc_field.
Test plan:
Confirm that the description is correctly displayed on the following
pages:
- detail and moredetail of a bibliographic page (itemlost, damaged,
materials)
- Set AcqCreateItem=ordering and receiving items.
The description for notforloan, restricted, location, ccode, etc.
field should be displayed.
- Items search form
- On the checkout list from the circulation.pl and returns.pl
pages, the description for "materials" should be displayed
Note that GetKohaAuthorisedValuesMapping is going to be removed on bug
17251.
Followed test plan, works as expected.
Signed-off-by: Marc Véron <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Kyle M Hall <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 1 -
C4/Items.pm | 45 +++++-----
C4/Koha.pm | 86 +++-----------------
C4/Search.pm | 3 +-
Koha/AuthorisedValues.pm | 28 ++++++-
acqui/orderreceive.pl | 36 ++++----
catalogue/detail.pl | 17 ++--
catalogue/getitem-ajax.pl | 31 +++----
catalogue/itemsearch.pl | 13 +--
catalogue/moredetail.pl | 16 ++--
circ/circulation.pl | 12 ++-
circ/returns.pl | 7 +-
t/db_dependent/AuthorisedValues.t | 11 ++-
t/db_dependent/Items/GetItemsForInventory.t | 3 +-
.../Koha/GetKohaAuthorisedValuesMapping.t | 54 ------------
tools/inventory.pl | 8 +-
16 files changed, 140 insertions(+), 231 deletions(-)
delete mode 100755 t/db_dependent/Koha/GetKohaAuthorisedValuesMapping.t
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
