This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ae8223e333201d264b19bf6ed9e91c10c94349ad (commit)
      from  5a08969a71dc27562a1a22af809673a8727f5c82 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ae8223e333201d264b19bf6ed9e91c10c94349ad
Author: Magnus Enger <>
Date:   Thu Sep 8 14:13:46 2016 +0200

    Bug 17265 - Make koha-create-defaults less greedy
    koha-create-defaults substitutes the instance name with the placeholder
    __KOHASITE__ in the SQL file that it creates. If the instance name is
    something common, like "data", this means that way too many substitutions
    will be made, and when koha-create uses the SQL file as a template, broken
    data can be the result.
    The solution in this patch was suggested by drojf on IRC.
    To test:
    - Create an instance called "data"
    - Run "sudo koha-dump-defaults data > test.sql"
    - Take a look at test.sql and verify there are way too many occurences
      of __KOHASITE__, like "-- Dumping __KOHASITE__ for table `accountlines`"
    - Apply the patch
    - Copy the resulting koha-create and koha-dump-defaults to somewhere
      running off the packages
    - Run "sudo koha-dump-defaults data > test.sql" again and verify there
      are only 4 occurrences of __KOHASITE__, in places that make sense
    - Create an instance with something like:
      $ gzip test.sql
      $ sudo koha-create --create-db --defaultsql test.sql.gz test17265
    - Verify that you have a working Koha install
    Signed-off-by: Andreas Roussos <>
    Works as expected.
    Signed-off-by: Kyle M Hall <>
    Signed-off-by: Kyle M Hall <>


Summary of changes:
 debian/scripts/koha-create        |    2 +-
 debian/scripts/koha-dump-defaults |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

main Koha release repository
koha-commits mailing list

Reply via email to