This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  90fea78bc15642798d9f7e9540c6f7f09258ff47 (commit)
       via  cb6c280c53c18ee8d25b71c8011dc9188ed3ccca (commit)
       via  e7aa94b78216e9c71c2ecbcec3b329db8af54f46 (commit)
       via  702c464c7472596022af17ff388793acfad008bb (commit)
       via  75a40acc39997a40aa8c692a58ec819630eb8f22 (commit)
       via  1240cd140890f9698202ac7682fae6864296e105 (commit)
       via  f353a6caacb8bc0c075106a1b1060db0495fdecf (commit)
       via  9f961c963d2a3131b3377bb444d4060ca3b74e8e (commit)
       via  84e17bd716bd2f561a58a7688700dddf2faa4b98 (commit)
       via  9d52044f65a611d49cd8f78f7aeaef24a018e357 (commit)
       via  a0919c3a29b70a83063a245da6e967ccf5328e4d (commit)
       via  ca0ca1b99e01baa913e2b5c56a87b529d8819bab (commit)
       via  25655c3bc56338ac5327745a9d3f2e378d37e8da (commit)
       via  340c18d8bc2c2b0691c0c45de201d4b663d90a47 (commit)
       via  607c66e436a0e4eddfb59f1c0ce6a69311c8e9ce (commit)
       via  d433a4dc3d18c68ed579c5c720465060602283b2 (commit)
       via  5b3b382f5814c2d30234e80d00f238547871d3e5 (commit)
       via  a037b80ee325e3828141ebc15533e8f3d159de5a (commit)
       via  5c8365e4a748a6e3eadddccc44a196087d4da279 (commit)
       via  fda87270ad49d403e70f3db4291c2ca65649cfeb (commit)
       via  710175fbe6721583028083d498f1df4a44bb1784 (commit)
       via  dc1e7f478f150a33d53a07114d65aead54569f48 (commit)
       via  e484b543f796df481edfb5e00920fb30c162fe80 (commit)
       via  fb2550de6e2c47ad83b63a196f50cbe1e0e16b43 (commit)
       via  38ae35332a60da74a69afb8765f8f2f3e870c11d (commit)
       via  55544f0187545747b1fbc2ce74ed44517ba7ca2f (commit)
       via  40ae454b9b0678d9e9f0418216bd546bc222e4f5 (commit)
       via  7809a6bd132e6bd2c98d69179fc2c2f0788decb0 (commit)
       via  032992042dc0dcc910465e1ded4b7bbb6d23e9f6 (commit)
       via  c6299bbca5dc1654652814f9792f276670e1ac7f (commit)
       via  ea15f3112b4de5d0fb76343d4545ccfd940d40fd (commit)
       via  fa54100dffe092e606f79b15692eedaf78f42e45 (commit)
       via  5f80977875ff124d411f2cd89de4a944fa9c27af (commit)
       via  e09ed656af5f75a82ccfa29318081e217618c32d (commit)
       via  6ef64cda22dc7a17c72215bbb0d74c240b314646 (commit)
       via  cee2cf9ff927504f9c24f6519462a7d702c5c27d (commit)
       via  4bc92169dcc04cd0bd586abf01828331711980cc (commit)
       via  4134df83734d2fabd4806339854cfab41faab82d (commit)
       via  d2f2590c894efca417112795e05248dbd16636f5 (commit)
       via  eb68ca2af2c9ebf32091f98380dbbd07cd7ff2e6 (commit)
       via  6e14fd52761f709f0644fe3a59700895cb1e7f87 (commit)
       via  95d0a17e8b873c493f099fc69772e4c50908a21c (commit)
       via  1cd2ad6e052d12e6ccf4d0b098ff2dd7a1fa526a (commit)
       via  a364bb15a7c7c49017d0a928bbe9e02038231419 (commit)
       via  1a0421dbf78e896d831c8ac5c1caf44b802208c2 (commit)
       via  bb02cd1a7375fe391c37408981662d70c6aa0499 (commit)
       via  dc475cceabba7fceb3e53a8021cd9799b46b7d4b (commit)
       via  ae870e767a3edbb786e4815220c57ca624e3d5e3 (commit)
       via  ad6a7aaf85d1c10fe74c9c1c503384b04372a29c (commit)
       via  6b106a7e7b8cb45a9f3794e325d12ad5799bb0a9 (commit)
       via  e667fc1cfc601704a72432c7efafdd1c40a6126f (commit)
       via  28dccc7a112065fa39d03ca44f864be9e3174c78 (commit)
       via  2059f7d8016ab61172830e9b670279d3e28882b7 (commit)
       via  d3d4820209ca8a35cf5fcce9595a8d7700ca9da9 (commit)
       via  bd81430d4209822e69d970db3aef520a6010c94f (commit)
       via  d1cd3d1e0520e87d373fe154946e95d64705812c (commit)
       via  ba4a808015ac1e172983487e590b097469970355 (commit)
       via  bc25710581e4e69abff401757ae6351601c19893 (commit)
       via  99543e96ab7fca91e9126db1ba9a4d838dc8e01e (commit)
       via  f32cdb7211705a0950e98897820f3a4a7bc52cd8 (commit)
       via  1c4d57a7906aba9f87c04924eadb231c6f727495 (commit)
       via  3fdb554ad8c349f78399fb14e9a2a2e502ed2ebc (commit)
       via  fbc466f93b3cd6900b8313db3314d2f1b946abdf (commit)
       via  4a2e3d1b1499c84fdc900e3fa2cc15e7f63494a2 (commit)
       via  1effa1b90fdf84b23934bb3b6d8f1d18fbd79641 (commit)
       via  5a02e867449b3f74f9b4dda44c2dfde3972de1be (commit)
       via  65d4289f129274a4ed504e7fb517623aeee1bb3b (commit)
       via  bf232417fc16a366cb1389d9d64b4f978144101d (commit)
       via  bb52f91d3c39944d7aa68b9ee1653e73c4397512 (commit)
       via  2cb369e5d23abfcd797832fb173b33afb9a6dbb2 (commit)
       via  6f2893c35bcf2aeb65680db3dc3d4dbdd51ab8e5 (commit)
       via  ee259d614000e0121f1567fd40b0721b23d100d5 (commit)
       via  bfb5ebc98856c111a6dcf32f1cd4cc0bb5d6c86b (commit)
       via  9d178613ad16d030ca9252d971f7efc615c8925f (commit)
      from  35b60cbd139146ecbce7a0b3ba7a51e912630c48 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 90fea78bc15642798d9f7e9540c6f7f09258ff47
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 15:42:03 2018 -0300

    Bug 20157: DBRev 17.12.00.011
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit cb6c280c53c18ee8d25b71c8011dc9188ed3ccca
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 11:17:37 2018 -0300

    Bug 20157: Group search groups together
    
    We do not actually need 2 groups, the previous feature worked for both
    OPAC and STAFF interface.
    The only difference was the "show_in_pulldown" feature.
    Here we are going to REMOVE this feature for ergonomic reasons. We will
    already have 3 features and it will surcharge the interface to add
    another one. Moreover the feature will have to be applied at the OPAC
    (and so will add lot of JS checks to keep data consistent: only useful
    if ft_search_groups_opac is set).
    Moreover it is quite easy to remove entry from the dropdown list in
    JavaScript.
    
    If people was really using this feature, we will re-add it, just let us
    know.
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit e7aa94b78216e9c71c2ecbcec3b329db8af54f46
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 10:49:56 2018 -0300

    Bug 20157: Do not display OPAC groups on the staff interface
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 702c464c7472596022af17ff388793acfad008bb
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 10:10:31 2018 -0300

    Bug 20157: Correctly hide the features for non first level groups
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 75a40acc39997a40aa8c692a58ec819630eb8f22
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 10:00:06 2018 -0300

    Bug 20157: Save the features that have been checked
    
    Previous patch forgot to modify the controller script to save the
    changes.
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 1240cd140890f9698202ac7682fae6864296e105
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Wed Feb 7 19:48:56 2018 +0000

    Bug 20157: DBIC Schema changes
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit f353a6caacb8bc0c075106a1b1060db0495fdecf
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Wed Feb 7 19:44:28 2018 +0000

    Bug 20157: Use group 'features' to decide which groups to use for group 
searching functionality
    
    Instead of basing the group searches on the group name, which is an
    inherently touchy system, we should use the same checkbox style that
    Jonathan introduced for the patron limits by group feature.
    
    Test Plan:
    1) Check to ensure existing group searches still show as they used to
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 9f961c963d2a3131b3377bb444d4060ca3b74e8e
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 15:40:42 2018 -0300

    Bug 20133: DBRev 17.12.00.010
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 84e17bd716bd2f561a58a7688700dddf2faa4b98
Author: Kyle M Hall <k...@bywatetsolutions.com>
Date:   Wed Feb 7 12:41:10 2018 -0500

    Bug 20133: (QA follow-up) Tweak new 'group features' section
    
    Signed-off-by: Kyle M Hall <k...@bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 9d52044f65a611d49cd8f78f7aeaef24a018e357
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 2 14:23:42 2018 -0300

    Bug 20133: Enable/disable the "Hide patron information" feature per group 
of libraries
    
    In order to control this feature correctly it needs to be enabled for
    group of libraries and not for all groups defined in the system.
    Groups will be used for different usages and so the feature must not be
    enabled by default for all of them.
    
    Test plan:
    Retest bug 18403 with the feature turned on/off for a given tree
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a0919c3a29b70a83063a245da6e967ccf5328e4d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 2 14:21:49 2018 -0300

    Bug 20133: UI Changes
    
    Add a checkbox to enable/disable the feature for given group of
    libraries.
    
    Important note: Only the top level node can turn the feature, the idea
    is to avoid confusion, ease testing (by limiting the number of cases)
    and force libraries to define one tree per feature (Maybe this is wrong,
    but maybe good to start)
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ca0ca1b99e01baa913e2b5c56a87b529d8819bab
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 2 14:21:26 2018 -0300

    Bug 20133: DBIC Schema changes
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 25655c3bc56338ac5327745a9d3f2e378d37e8da
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 2 14:21:14 2018 -0300

    Bug 20133: Add new column library_groups.ft_hide_patron_info
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 340c18d8bc2c2b0691c0c45de201d4b663d90a47
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 15:38:54 2018 -0300

    Bug 18403: DBRev 17.12.00.009
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 607c66e436a0e4eddfb59f1c0ce6a69311c8e9ce
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 12 14:14:32 2018 -0300

    Bug 18403: Fix few errors found with hit_pages.t
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit d433a4dc3d18c68ed579c5c720465060602283b2
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 16:57:01 2018 -0300

    Bug 18403: Add POD for output_and_exit_if_error
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 5b3b382f5814c2d30234e80d00f238547871d3e5
Author: Kyle M Hall <k...@bywatetsolutions.com>
Date:   Fri Feb 9 08:51:02 2018 -0500

    Bug 18403: Fix error triggered by subgroups being added to group
    
    With one root group and two child groups and it works fine.
    But if I create any groups under *those* groups, not only does it not work,
    I get the following error:
    Template process failed: undef error - SQL::Abstract::puke(): 
[SQL::Abstract::__ANON__]
    Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the 
-IN operator was
    given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the
    upcoming Data::Query-based version of SQL::Abstract will
    emit the logically correct SQL instead of raising this
    exception) at /home/vagrant/kohaclone/Koha/Objects.pm line 269
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a037b80ee325e3828141ebc15533e8f3d159de5a
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 12 09:56:22 2017 -0300

    Bug 18403: Deal with the DB user
    
    On first login, Koha explodes before the logged in user does not exist
    in DB.
    This patch deals with that by adding several checks when it's needed.
    
    Test plan:
    Use the DB user to create a superlibrarian user.
    The DB user should no be allowed to do anything else.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Bug 18403: Fix patron creation
    
    memberentry.pl can be called to create a new patron, in that case the
    patron does not exist yet.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 5c8365e4a748a6e3eadddccc44a196087d4da279
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Apr 10 17:34:34 2017 -0300

    Bug 18403: REST API - patrons endpoint
    
    There is something wrond here, the userenv is no set and so we cannot
    user search_limited.
    Should we set the userenv or filter on the libraries using
    libraries_where_can_see_patrons?
    WAITING FOR FEEDBACK HERE.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit fda87270ad49d403e70f3db4291c2ca65649cfeb
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Apr 10 10:23:37 2017 -0300

    Bug 18403: Guarantors
    
    Technically a kid from your library group could have a guarantor
    attached to another
    group of library, let's deal with this case.
    
    Test plan:
    - Create a kid from your library group
    - With a superlibrarian staff user create a guarantor that is outside of
    the group of
    libraries of the kid
    - Login with a limited staff user and confirm that on the patron detail
    page you do not
    see the link to the guarantor detail page.
    
    Note that you see the firstname and surname of the guarantor
    Q. should it be hidden?
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 710175fbe6721583028083d498f1df4a44bb1784
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Apr 7 17:53:35 2017 -0300

    Bug 18403: Article requests
    
    Same as previously but for article requests.
    
    Test plan:
    Test article requests and make sure you do not need the requests for
    patrons that
    are attached to a group that is not part of your library's group
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit dc1e7f478f150a33d53a07114d65aead54569f48
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Apr 7 15:42:51 2017 -0300

    Bug 18403: Patron discharges
    
    This patch deals with patron's discharges.
    
    Test plan:
    Same as previously you will need to request dischages at the OPAC.
    On the staff interface the logged in user should not be allowed to see
    discharge
    from patrons outside his library group.
    The number of discharges waiting displayed on the mainpage should be
    correct as well.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Bug 18403: (follow-up) Patron discharges
    
    Fix QA issue:
    forbidden pattern: Do not assume male gender, use they/them instead (bug 
18432) (line 150)
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit e484b543f796df481edfb5e00920fb30c162fe80
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Apr 7 14:37:47 2017 -0300

    Bug 18403: Patron reviews
    
    This patch adds a new method Koha::Reviews->search_limited to return the
    reviews
    a logged in user is allowed to see depending his permissions.
    
    Test plan:
    Create some reviews at the OPAC and make sure a staff user is limited
    (or not) to approve
    or decline it.
    The number of reviews displayed on the mainpage should be correct as
    well.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit fb2550de6e2c47ad83b63a196f50cbe1e0e16b43
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Apr 7 14:02:09 2017 -0300

    Bug 18403: Patron modification requests
    
    Limit patron's modifications based on logged in patron permissions.
    
    Test plan:
    Create some patron's modification requests at the OPAC
    Make sure the logged in staff user see (or not) the modification depending 
his
    permissions.
    The number of modification displayed on the mainpage should be correct as 
well.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 38ae35332a60da74a69afb8765f8f2f3e870c11d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Apr 7 14:00:34 2017 -0300

    Bug 18403: Add new method Koha::Patron->can_see_patrons_from
    
    Technical note:
    Sometimes we do not have the patron object, for instance for the patron 
modifications
    we will need to know if the logged in user can modify patron's from a given 
library.
    This new subroutine 'can_see_patrons_from' will then be useful
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 55544f0187545747b1fbc2ce74ed44517ba7ca2f
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 07:34:47 2017 -0300

    Bug 18403: Add tests for Koha::Patrons
    
    A bit late but here are the tests for
     Koha::Patron->libraries_where_can_see_patrons
     Koha::Patron->can_see_patron_infos
     Koha::Patron->search_limited
    
    Test plan:
      prove t/db_dependent/Koha/Patrons.t
    should return green
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 40ae454b9b0678d9e9f0418216bd546bc222e4f5
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Thu Apr 6 12:59:46 2017 -0300

    Bug 18403: Refactor and add Koha::Patron->libraries_where_can_see_patrons
    
    Technical note:
    Here we are just refactoring a code that have been copied into 3 different 
places.
    libraries_where_can_see_patrons is a terrible method's name, feel free to 
suggest
    something better. The method return a list of branchcodes to be more 
efficient,
    instead of Koha::Libraries
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 7809a6bd132e6bd2c98d69179fc2c2f0788decb0
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Thu Apr 6 12:42:03 2017 -0300

    Bug 18403: Add new methods Koha::Patrons->search_limited and use it where 
needed
    
    Most of the time when we search for patrons we do not want to search for 
all patrons,
    but just the ones the logged in user is allowed to see the information.
    This patch takes care of that by adding a new search_limited method to 
Koha::Patrons.
    When called this method only search for patrons that the logged in user is 
allowed
    to see.
    
    Test plan:
    Patron autocomplete search should be limited
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 032992042dc0dcc910465e1ded4b7bbb6d23e9f6
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 18:55:13 2017 -0300

    Bug 18403: output_and_exit_if_error for circulation.pl
    
    This is a follow-up for a previous patch, changes have been tested
    already
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit c6299bbca5dc1654652814f9792f276670e1ac7f
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 18:47:30 2017 -0300

    Bug 18403: Batch patron modification tool
    
    Do not allow a logged in staff user to modify patrons that are not part of 
his
    group if he is not allowed.
    
    Test plan:
    Make sure you are not allowed to modify patrons that are not part of your 
group
    from the batch patron modification tool
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ea15f3112b4de5d0fb76343d4545ccfd940d40fd
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 17:25:13 2017 -0300

    Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for 
view_holdsqueue]
    
    Same that the previous patch but for the holds queue
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit fa54100dffe092e606f79b15692eedaf78f42e45
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 17:04:36 2017 -0300

    Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for 
issuehistory]
    
    On this page we do not have the patron object sent to the template,
    let's pass it!
    
    Test plan:
    Go on the checkout history of a bibliographic record
    (catalogue/issuehistory.pl)
    You should not see patron's information that are not part of your group
    if you
    are not allowed to see them.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 5f80977875ff124d411f2cd89de4a944fa9c27af
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 16:43:41 2017 -0300

    Bug 18403: Use patron-title.inc when hidepatronname is used
    
    There is already a HidePatronName syspref to hide patron's information
    on bibliographic
    record detail pages and the hold list.
    
    Test plan:
    With the HidePatronName enabled, make sure the patron's information are
    hidden from
    the catalogue and hold list pages. If the logged in user is not allowed
    to see the
    patron's info, no link and no cardnumber will be displayed
    With he HidePatronName disabled, make sure the patron's information are
    displayed
    if the logged in user is allowed to see the patron's info.
    
    Technical note:
    This patch improves the existing patron-title.inc include file to
    display patron's
    information. Using it everywhere patron's details are displayed will
    permit to
    homogenise the way they are displayed. The file takes now a patron
    object (what
    should be, in the future, the only way to use it), that way we can call
    the new
    method on it to know if patron's information can be shown by the logged
    in used.
    
    NOTE: I am not sure this syspref makes sense anymore. Should not we
    remove it?
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit e09ed656af5f75a82ccfa29318081e217618c32d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 14:11:02 2017 -0300

    Bug 18403: Only display libraries from group in dropdown lists
    
    From where patrons it's about patrons, we do not want to display the 
libraries
    from all the system, but only the ones from the group.
    
    Test plan:
    - See the overdues (circ/overdue.pl) and make sure you can only see 
overdues from
    patrons part of your group (do not forget to test the CSV export).
    - Search for patrons, the 'library' filters (headers and left side) should 
only
    display libraries from your group
    - Search for article request by patron's library: only the libraries from 
your
    group should be displayed
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 6ef64cda22dc7a17c72215bbb0d74c240b314646
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Wed Apr 5 13:19:42 2017 -0300

    Bug 18403: Adapt patron search
    
    This patch modifies the patron search code to limit the libraries to the
    ones
    the logged in user is allowed to access
    
    Test plan:
    Search for patrons
    You should not see patrons you are not allowed to see.
    
    Technical note:
    I am really glad to have refactored all the patron searches before
    having to
    write this patch. It tooks me ~40 l to acchieve this job and affect all
    patron searches.
    Thanks refactoring!
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit cee2cf9ff927504f9c24f6519462a7d702c5c27d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Apr 4 18:48:45 2017 -0300

    Bug 18403: Add sub output_and_exit_if_error - unknown_patron & 
cannot_see_patron_infos
    
    Test plan:
    Login with a patron that is not allowed to see patron's information for 
patrons
    outside of his group. Try to access patron's information from scripts of 
the patron
    module (members/*) and circ/circulation.pl.
    You should be able to access patron's information of patrons outside of 
your group
    and get "You are not allowed to see the information of this patron."
    If you try and access a patron page with a borrowernumber that does not 
exist, you
    should get "This patron does not exist"
    
    Technical note:
    A new C4::Output subroutine is created in this patch: 
"output_and_exit_if_error"
    Executed at the beginning of the script it will permit not to copy/paste 
all the
    different checks to know if the logged in user is authorised to see 
patron's information.
    The design here can be discussed, but I did not find an alternative with as 
less changes.
    On the way I refactor what we did with 'unknowuser' previously: it will now 
work with all
    patron pages, not only the few that used it.
    Note that the 'or die "Not logged in";' part should not be needed, but... 
who trusts
    C4::Auth?
    I think it could be used as a safeguard later. I am willing to sed and 
remove them
    if required.
    
    Changes in discharge.pl are mainly indentation changes.
    
    With this patch we should now have a $patron variable that refer to the 
patron we
    want to access. That will be very useful to remove plenty of code in 
members/* and
    only pass this variable to the template (instead of 1 variable per patron's 
attribute).
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 4bc92169dcc04cd0bd586abf01828331711980cc
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Apr 4 17:45:30 2017 -0300

    Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 
'edit_borrowers'
    
    Test plan:
    Login with a patron that only have the 'edit_borrowers' permission.
    You should be able to access patron's information of patrons inside of your 
group.
    
    Technical note:
    Before this patchset the borrowers permission module contains only 1 
permission 'edit_borrowers'.
    That meant
      borrowers => 1
    and
      borrowers => '*'
    had the same behavior.
    Moreover, now that we have 2 permissions, 'CAN_user_borrowers' is set when 
all
    permissions of 'borrowers' are set.
    We need to update the different occurrences of these tests.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 4134df83734d2fabd4806339854cfab41faab82d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Thu Apr 6 16:10:18 2017 -0300

    Bug 18403: Add new method Koha::Patron->can_see_patron_info
    
    Technical note:
    This is the method that will be called on the logged_in_user variable sent 
to
    the template. Moreover we will check that the logged in user can access 
patron'
    information when access to members/* and some circulation scripts will be 
done.
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit d2f2590c894efca417112795e05248dbd16636f5
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Apr 4 16:43:58 2017 -0300

    Bug 18403: Send logged_in_user to template from C4::Auth
    
    Technical note:
    To ease future changes we are passing a logged_in_user variable to 
templates.
    It contains the Koha::Patron object representing the logged in patron.
    This will be very useful for this patch and even after (for instance we 
will be
    able to replace easily loggedinusername and loggedinusernumber).
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit eb68ca2af2c9ebf32091f98380dbbd07cd7ff2e6
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Thu Apr 6 16:10:02 2017 -0300

    Bug 18403: Add new method Koha::Library::Group->has_child
    
    This is more a follow-up for bug 15707. It could be moved on its own bug 
report
    if necessary.
    
    IMPORTANT NOTE: At the moment the feature only works for 1 level depth, see
    bug 15707 comment 166+ for the discussion
    
    It means that if we have:
     root_group
         + groupA
             + groupA1
                 + groupA1_library2
             + groupA_library1
             + groupA2
         + groupB
             + groupB_library1
    groupA1_library2 is not considered a child of groupA1.
    Note that this can change.
    
    Test plan:
      prove t/db_dependent/LibraryGroups.t
    should return green
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 6e14fd52761f709f0644fe3a59700895cb1e7f87
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Thu Apr 6 16:09:46 2017 -0300

    Bug 18403: Add new method Koha::Library->library_group
    
    This is more a follow-up for bug 15707. It could be moved on its own bug 
report
    if necessary.
    
    Test plan:
      prove t/db_dependent/LibraryGroups.t
    should return green
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 95d0a17e8b873c493f099fc69772e4c50908a21c
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Apr 4 16:01:41 2017 -0300

    Bug 18403: Hide patron information if not part of the logged in user 
library group
    
    This patchset adds a new feature that will allow libraries inside a
    single Koha installation to restrict access to information of patrons
    that
    
    The group of libraries feature is introduced by bug 15707, see this bug for 
more
    information.
    
    Let's imagine that 2 groups G1 and G2 are defined and that they include 2 
libraries
    each G1a, G1b and G2c, G2d: logged in users attached to G1a will only see 
patron's
    information from G1a and G1b.
    To add more flexibility, a new user permission named 
'view_borrower_infos_from_any_libraries'
    will drive this behavior. If set, the patron will be able to see patron's 
information
    of any libraries.
    
    If the restriction is set, the logged in user will not be able to search, 
show, edit,
    delete patron's information of patrons attached to groups of libraries 
outside his
    own group.
    In situations we need to refer to a patron, for holds and checkouts for 
instance,
    and his information cannot be viewed, a text "A patron from library G1A" 
will be
    displayed.
    
    Considered unecessary or outside the scope of this bug report:
    * The report module is not affected by this feature for obvious reasons
    * The firstname and surname of guarantors, basket (acq) managers, patrons 
linked
    to orders are still displayed.
    * Log viewer: Can only be staff
    * patron list: you cannot add patrons from another group of librairies, but 
can
    see/delete from list (too much rewrite, or we can test for patron one by 
one?).
    * "Patron card creator" tool is not impacted by this feature.
    * Upload patron images is not impacted by this patch, should it be?
    * Tools:
      - Upload patrons
      - Clean borrowers tool (This can can done easily updating 
Koha::Patrons->search
    with Koha::Patrons->search_limited in search_upcoming_membership_expires and
    search_patrons_to_anonymise but we will need to move GetBorrowersToExpunge 
to
    Koha::Patrons first)
    We can discuss these different points but will be other bug reports not to 
add
    more complexity to this first patchset.
    
    Test plan:
    You will find a test plan in the following commit messages.
    Start by creating different group of libraries and patrons with and without 
the
    new permission. Open different browser sessions to ease the tests.
    Note that all patches have to be applied to test the different test plans.
    
    Technical notes:
    For QAers (and others) a techical note will be added to the commit messages 
of this
    patchset. I would recommend you to read them one by one to understand the 
different
    steps of this development.
    
    + Special attention should be payed to the REST api changes
    + Should we restrict the logged in user to libraries from his group when
    he wants to set his library (Home › Circulation › Set library)?
    
    Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgo...@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 1cd2ad6e052d12e6ccf4d0b098ff2dd7a1fa526a
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 15:44:25 2018 -0300

    Bug 16735: DBRev 17.12.00.008
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a364bb15a7c7c49017d0a928bbe9e02038231419
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Dec 5 14:09:23 2017 -0300

    Bug 16735: DBIC Schema files
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 1a0421dbf78e896d831c8ac5c1caf44b802208c2
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 17:00:44 2018 -0300

    Bug 16735: Fix POD format for Koha::Library::Groups methods
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit bb02cd1a7375fe391c37408981662d70c6aa0499
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 11:35:03 2018 -0300

    Bug 16735: Remove unecessary use of Koha::LibraryCategories in onboarding
    
    This was not used, it has been copied/pasted from admin/branches.pl
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit dc475cceabba7fceb3e53a8021cd9799b46b7d4b
Author: Tomas Cohen Arazi <tomasco...@theke.io>
Date:   Mon Dec 11 13:29:33 2017 -0300

    Bug 16735: (QA follow-up) Fix rebase error
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ae870e767a3edbb786e4815220c57ca624e3d5e3
Author: Tomas Cohen Arazi <tomasco...@theke.io>
Date:   Mon Dec 11 12:46:05 2017 -0300

    Bug 16735: (QA follow-up) POD fixes
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ad6a7aaf85d1c10fe74c9c1c503384b04372a29c
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Aug 8 12:40:45 2017 -0400

    Bug 16735: Use libraries in all subgroups, not just immediate children
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 6b106a7e7b8cb45a9f3794e325d12ad5799bb0a9
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Feb 21 13:36:22 2017 +0000

    Bug 16735: Filter individual libraries from search group pulldown
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit e667fc1cfc601704a72432c7efafdd1c40a6126f
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Feb 21 12:26:25 2017 +0000

    Bug 16735: Remove use of get_categories
    
    Feature using it is completely undocumented as far as my research has
    shown.
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 28dccc7a112065fa39d03ca44f864be9e3174c78
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Feb 21 12:07:18 2017 +0000

    Bug 16735: Don't use objects for database update
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 2059f7d8016ab61172830e9b670279d3e28882b7
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Wed Jun 22 17:10:23 2016 +0000

    Bug 16735: Migrate library search groups into the new hierarchical groups
    
    Test Plan:
    1) Apply this patch set
    2) Note your existing search groups have been ported over to the new
       __SEARCH_GROUPS__ group if you had any
    3) Create the group __SEARCH_GROUPS__ if one does not already exist
    4) Add some first level subgroups to this group, add libraries to those 
groups
    5) Search the library group searching in the intranet and opac
    6) Note you get the same results as pre-patch
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit d3d4820209ca8a35cf5fcce9595a8d7700ca9da9
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Thu Jun 23 13:24:54 2016 +0000

    Bug 16735: Clean up sample data
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit bd81430d4209822e69d970db3aef520a6010c94f
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Thu Jun 23 11:44:15 2016 +0000

    Bug 16735: Remove tables no longer needed
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit d1cd3d1e0520e87d373fe154946e95d64705812c
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Wed Jun 22 18:28:03 2016 +0000

    Bug 16735: Remove modules no longer needed
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ba4a808015ac1e172983487e590b097469970355
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Fri Feb 9 15:13:35 2018 -0300

    Bug 15707: DBRev 17.12.00.007
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit bc25710581e4e69abff401757ae6351601c19893
Author: Tomas Cohen Arazi <tomasco...@theke.io>
Date:   Wed Dec 6 16:12:47 2017 -0300

    Bug 15707: (QA follow-up) Style buttons correctly
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 99543e96ab7fca91e9126db1ba9a4d838dc8e01e
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Dec 5 14:05:28 2017 -0300

    Bug 15707: DBIC Schema files
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit f32cdb7211705a0950e98897820f3a4a7bc52cd8
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Wed Mar 1 13:58:54 2017 +0000

    Bug 15707: Display error if group title is already used
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    Edit: I added !$branchcode && to the checked condition so we can add 
multiple
    libraries back.
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 1c4d57a7906aba9f87c04924eadb231c6f727495
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Wed Feb 22 19:54:58 2017 +0000

    Bug 15707: Updates for Bootstrap 3
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 3fdb554ad8c349f78399fb14e9a2a2e502ed2ebc
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Feb 21 12:21:12 2017 +0000

    Bug 15707: Add UNIQUE constraint to library groups table
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit fbc466f93b3cd6900b8313db3314d2f1b946abdf
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Feb 21 12:16:03 2017 +0000

    Bug 15707: Switch datetimes to timestamps
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 4a2e3d1b1499c84fdc900e3fa2cc15e7f63494a2
Author: Josef Moravec <josef.mora...@gmail.com>
Date:   Wed Dec 7 01:01:52 2016 +0000

    Bug 15707: (follow-up) use cat-search instead of cities-search in header
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 1effa1b90fdf84b23934bb3b6d8f1d18fbd79641
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Mon Jun 20 11:45:10 2016 +0000

    Bug 15707: (QA follow-up) Allow object names to be styled without impeding 
translation
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 5a02e867449b3f74f9b4dda44c2dfde3972de1be
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Jun 14 13:20:32 2016 +0000

    Bug 15707: (QA follow-up) Remove class for treegrid
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 65d4289f129274a4ed504e7fb517623aeee1bb3b
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Jun 14 11:55:25 2016 +0000

    Bug 15707: (QA follow-up) Fix UI issues
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit bf232417fc16a366cb1389d9d64b4f978144101d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Sun Jun 12 10:15:38 2016 +0100

    Bug 15707: (QA follow-up) Drop table if exists
    
    1/ DROP table if exists
    2/ FAIL   spelling
        decendents  ==> descendants
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit bb52f91d3c39944d7aa68b9ee1653e73c4397512
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Tue Apr 19 13:33:39 2016 +0000

    Bug 15707: (QA follow-up) Switch to treetable which Koha already uses
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 2cb369e5d23abfcd797832fb173b33afb9a6dbb2
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 15 17:24:35 2016 +0000

    Bug 15707: Fix conflict with bug 15446 (type vs _type)
    
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 6f2893c35bcf2aeb65680db3dc3d4dbdd51ab8e5
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Fri Feb 5 06:53:20 2016 +0000

    Bug 15707: Unit Tests
    
    Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ee259d614000e0121f1567fd40b0721b23d100d5
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Sun Jan 31 11:22:51 2016 +0000

    Bug 15707: Add library groups editor
    
    Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit bfb5ebc98856c111a6dcf32f1cd4cc0bb5d6c86b
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Sun Jan 31 11:22:19 2016 +0000

    Bug 15707: Add Koha::Library::Group(s) modules
    
    Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 9d178613ad16d030ca9252d971f7efc615c8925f
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Sun Jan 31 11:21:00 2016 +0000

    Bug 15707: Update DB
    
    Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |   26 +-
 C4/Circulation.pm                                  |   29 --
 C4/Output.pm                                       |   40 ++
 C4/SIP/ILS/Transaction/Checkin.pm                  |    2 +-
 C4/Utils/DataTables/Members.pm                     |   42 ++-
 Koha.pm                                            |    2 +-
 Koha/ArticleRequests.pm                            |   39 +-
 Koha/Hold.pm                                       |    1 +
 Koha/Libraries.pm                                  |   17 +-
 Koha/Library.pm                                    |   43 +--
 Koha/Library/Group.pm                              |  208 +++++++++++
 Koha/{Serial/Items.pm => Library/Groups.pm}        |   48 ++-
 Koha/LibraryCategories.pm                          |   52 ---
 Koha/LibraryCategory.pm                            |   58 ---
 Koha/Patron.pm                                     |   96 +++++
 Koha/Patron/Discharge.pm                           |   30 +-
 Koha/Patron/Modifications.pm                       |   49 ++-
 Koha/Patrons.pm                                    |   21 ++
 Koha/REST/V1/Patron.pm                             |    3 +-
 Koha/Reviews.pm                                    |   23 ++
 Koha/Schema/Result/Branch.pm                       |   44 +--
 Koha/Schema/Result/Branchcategory.pm               |  116 ------
 Koha/Schema/Result/Branchrelation.pm               |  115 ------
 .../Result/{ClubTemplate.pm => LibraryGroup.pm}    |  147 ++++----
 Koha/Template/Plugin/Branches.pm                   |    3 +-
 Koha/Template/Plugin/{KohaDates.pm => KohaSpan.pm} |   19 +-
 admin/branches.pl                                  |   85 +----
 admin/library_groups.pl                            |  119 ++++++
 api/v1/swagger/paths/holds.json                    |    2 +-
 api/v1/swagger/paths/patrons.json                  |    4 +-
 catalogue/detail.pl                                |   13 +-
 catalogue/issuehistory.pl                          |   20 +-
 catalogue/moredetail.pl                            |   13 +-
 catalogue/search.pl                                |   13 +-
 circ/add_message.pl                                |    2 +-
 circ/branchtransfers.pl                            |    4 -
 circ/circulation.pl                                |    5 +
 circ/del_message.pl                                |    2 +-
 circ/overdue.pl                                    |   12 +-
 circ/returns.pl                                    |    7 -
 circ/view_holdsqueue.pl                            |    3 +
 circ/ysearch.pl                                    |    2 +-
 edithelp.pl                                        |    2 +-
 .../data/mysql/en/optional/sample_libraries.sql    |    2 -
 .../data/mysql/es-ES/optional/sample_libraries.sql |    4 -
 installer/data/mysql/kohastructure.sql             |   52 ++-
 .../mysql/nb-NO/2-Valgfritt/sample_libraries.sql   |    4 -
 .../data/mysql/pl-PL/optional/sample_libraries.sql |    4 -
 .../data/mysql/ru-RU/optional/example_branches.sql |   19 -
 installer/data/mysql/updatedatabase.pl             |  104 ++++++
 installer/data/mysql/userpermissions.sql           |    2 +
 installer/onboarding.pl                            |   16 -
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    5 +
 .../prog/en/includes/acquisitions-toolbar.inc      |    1 +
 .../intranet-tmpl/prog/en/includes/admin-menu.inc  |    3 +-
 .../intranet-tmpl/prog/en/includes/adv-search.inc  |    4 +-
 .../prog/en/includes/authorities-toolbar.inc       |    1 +
 .../prog/en/includes/blocking_errors.inc           |   10 +
 .../prog/en/includes/borrower_debarments.inc       |    6 +-
 .../prog/en/includes/budgets-admin-toolbar.inc     |    1 +
 .../intranet-tmpl/prog/en/includes/cat-toolbar.inc |    1 +
 .../intranet-tmpl/prog/en/includes/circ-menu.inc   |   16 +-
 .../intranet-tmpl/prog/en/includes/header.inc      |    2 +-
 .../intranet-tmpl/prog/en/includes/home-search.inc |    4 +-
 .../prog/en/includes/labels-toolbar.inc            |    1 +
 .../prog/en/includes/members-menu.inc              |    2 +-
 .../prog/en/includes/members-toolbar.inc           |   17 +-
 .../prog/en/includes/patron-search.inc             |    2 +-
 .../prog/en/includes/patron-title.inc              |  100 +++--
 .../prog/en/includes/patron-toolbar.inc            |    1 +
 .../prog/en/includes/patroncards-toolbar.inc       |    1 +
 .../intranet-tmpl/prog/en/includes/permissions.inc |    2 +
 .../prog/en/includes/reports-toolbar.inc           |    1 +
 .../en/includes/rotating-collections-toolbar.inc   |    1 +
 .../prog/en/includes/serials-toolbar.inc           |    1 +
 .../prog/en/includes/virtualshelves-toolbar.inc    |    2 +
 .../prog/en/modules/admin/admin-home.tt            |    6 +-
 .../prog/en/modules/admin/branches.tt              |  140 +------
 .../prog/en/modules/admin/library_groups.tt        |  395 ++++++++++++++++++++
 .../prog/en/modules/catalogue/advsearch.tt         |   22 +-
 .../prog/en/modules/catalogue/detail.tt            |   22 +-
 .../prog/en/modules/catalogue/issuehistory.tt      |   31 +-
 .../prog/en/modules/circ/article-requests.tt       |    2 +-
 .../prog/en/modules/circ/circulation.tt            |    4 +-
 .../en/modules/circ/circulation_batch_checkouts.tt |    2 +-
 .../intranet-tmpl/prog/en/modules/circ/overdue.tt  |   11 +-
 .../prog/en/modules/circ/view_holdsqueue.tt        |   12 +-
 .../prog/en/modules/common/patron_search.tt        |    2 +-
 .../intranet-tmpl/prog/en/modules/intranet-main.tt |    8 +-
 .../prog/en/modules/members/discharge.tt           |    4 +-
 .../prog/en/modules/members/discharges.tt          |    2 +-
 .../intranet-tmpl/prog/en/modules/members/files.tt |    4 +-
 .../prog/en/modules/members/housebound.tt          |    4 -
 .../prog/en/modules/members/member.tt              |    4 +-
 .../prog/en/modules/members/memberentrygen.tt      |   17 +-
 .../prog/en/modules/members/moremember.tt          |   21 +-
 .../prog/en/modules/members/printfeercpt.tt        |    1 +
 .../prog/en/modules/members/statistics.tt          |    6 +-
 .../prog/en/modules/reserve/request.tt             |    8 +-
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |   26 +-
 .../bootstrap/en/modules/opac-advsearch.tt         |    6 +-
 labels/label-item-search.pl                        |    2 +-
 mainpage.pl                                        |    6 +-
 members/boraccount.pl                              |    6 +-
 members/default_messageprefs.pl                    |    2 +-
 members/deletemem.pl                               |   17 +-
 members/discharge.pl                               |   14 +-
 members/discharges.pl                              |   10 +-
 members/files.pl                                   |   14 +-
 members/guarantor_search.pl                        |    2 +-
 members/housebound.pl                              |   12 +-
 members/mancredit.pl                               |    9 +-
 members/maninvoice.pl                              |   13 +-
 members/member-flags.pl                            |    7 +-
 members/member-password.pl                         |   11 +-
 members/member.pl                                  |    2 +-
 members/memberentry.pl                             |   22 +-
 members/members-home.pl                            |    2 +-
 members/members-update-do.pl                       |    8 +-
 members/members-update.pl                          |    2 +-
 members/mod_debarment.pl                           |   10 +-
 members/moremember.pl                              |   15 +-
 members/nl-search.pl                               |    2 +-
 members/notices.pl                                 |    5 +-
 members/pay.pl                                     |   11 +-
 members/paycollect.pl                              |    9 +-
 members/print_overdues.pl                          |    6 +
 members/printfeercpt.pl                            |   11 +-
 members/printinvoice.pl                            |   11 +-
 members/printslip.pl                               |    5 +
 members/purchase-suggestions.pl                    |   11 +-
 members/readingrec.pl                              |   10 +-
 members/routing-lists.pl                           |    9 +-
 members/setstatus.pl                               |   26 +-
 members/statistics.pl                              |   11 +-
 members/summary-print.pl                           |    9 +-
 members/update-child.pl                            |   12 +-
 opac/opac-memberentry.pl                           |    2 +-
 opac/opac-overdrive-search.pl                      |    2 +-
 opac/opac-search.pl                                |   10 +-
 reserve/request.pl                                 |    9 +-
 reviews/reviewswaiting.pl                          |    4 +-
 svc/checkouts                                      |    2 +-
 svc/members/search                                 |    2 +-
 t/db_dependent/ArticleRequests.t                   |   36 +-
 t/db_dependent/Koha/Libraries.t                    |   37 +-
 t/db_dependent/Koha/Patron/Modifications.t         |   39 +-
 t/db_dependent/Koha/Patrons.t                      |  115 +++++-
 t/db_dependent/Koha/Reviews.t                      |   36 +-
 t/db_dependent/LibraryGroups.t                     |  126 +++++++
 t/db_dependent/Patron/Borrower_Discharge.t         |   55 ++-
 t/db_dependent/RotatingCollections.t               |    1 -
 tools/modborrowers.pl                              |   58 ++-
 tools/tools-home.pl                                |    2 +-
 154 files changed, 2229 insertions(+), 1374 deletions(-)
 create mode 100644 Koha/Library/Group.pm
 copy Koha/{Serial/Items.pm => Library/Groups.pm} (50%)
 delete mode 100644 Koha/LibraryCategories.pm
 delete mode 100644 Koha/LibraryCategory.pm
 delete mode 100644 Koha/Schema/Result/Branchcategory.pm
 delete mode 100644 Koha/Schema/Result/Branchrelation.pm
 copy Koha/Schema/Result/{ClubTemplate.pm => LibraryGroup.pm} (55%)
 copy Koha/Template/Plugin/{KohaDates.pm => KohaSpan.pm} (71%)
 create mode 100755 admin/library_groups.pl
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc
 create mode 100644 
koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
 create mode 100644 t/db_dependent/LibraryGroups.t


hooks/post-receive
-- 
main Koha release repository
_______________________________________________
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits

Reply via email to