This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ea7fa8d011afc6d2337aebb440c1bf1f4732b143 (commit)
       via  fc30a2c82c487fdf6da354cccd86c29b2c1d4aee (commit)
       via  53e46a58624f14f6528b6bd06c0eb39bd09b9e0f (commit)
       via  fb16189e0bedb6c2c91d778ca842cfca2507018c (commit)
       via  3f69f6e1c8738564c30d613d245ea8af5f6b91fd (commit)
       via  410e3c81d59f27e4e21d4f55d45c9de74f6d80d9 (commit)
       via  0fe8670547ec0fe3e55f8e0dbb77fbf07f141601 (commit)
       via  129270cd4657f6b13b3890920cbd75cd83595187 (commit)
       via  44ca7c37acd2b5f16160c03d8772c1ff01f3990a (commit)
       via  a93e49131d4d22c5bc2123f9a3626c36845d9e07 (commit)
       via  8a0e21f0ecfd7e5bd135ad30e8955960b5d3549d (commit)
       via  cf26f1f41f5d0d6ebedfe46b9405dc3b8fc71506 (commit)
       via  b8f0a3fc40ce4aa64dec1c819a936d7397970ddf (commit)
       via  ffae331219341978582bc1db7a03b2c6449b7227 (commit)
       via  21922eeac502d055ee5eaaf59da0ae8d251d37a3 (commit)
       via  29434b14549144589cc0663a25246914cb093d3d (commit)
       via  6f75f7bb9eec1325cf3c1527c571fbe392b478ad (commit)
       via  39b0b5909cb0bc271b85723eb32d02146649b3be (commit)
       via  2e35da4f6b0e2c25ca1e6acb3e80f8b9d65cb658 (commit)
       via  406a480a780e67d3386e354907f8fac674257c17 (commit)
       via  51ddaa78953b4751d193ebfec2efbf331c6f8502 (commit)
       via  61679027b50baac783bd9f8914d5d31ac4364bb2 (commit)
       via  d43eb8b19c8b9fe51c5a6bde0a565fe363596e36 (commit)
       via  db181fd8e15df0309898e3c6b62ed6446a68d526 (commit)
       via  a2292e83f13f499472e251995596ff04c263339d (commit)
       via  23018e15127c163ffb1559c3627cc261e846df07 (commit)
       via  cbd566caf6e827e67c20d7d06de2e5bd7036dff5 (commit)
       via  3755a38acfd4972d794bef8cb844e5474c3c4112 (commit)
       via  666cbed5e17f8b644300c43091231554eaeb3eb0 (commit)
       via  2decad7b43e298524c0aea812462b73c7f088573 (commit)
       via  e053ccb682402d57253471d8f07dcf906ea288c0 (commit)
       via  294ea88614ab8683904dee5123d69c896a174f59 (commit)
       via  6d439a5c5852db2c524c5ba027d0ce58c0d8d537 (commit)
       via  7b51c8e443e32cdad241b032bca042a53c698769 (commit)
       via  ae63d6e27156981a171540c0180a96f86c3fc184 (commit)
       via  ecc69f0ab24c926696ae1c537589801e0f41d9b5 (commit)
       via  f854d16def40a97df326e356063bd931d03c3032 (commit)
       via  5693d255d553e8670cb5da7a9f65e3e9a6a229bb (commit)
       via  2bb3392156e4314b948c39e4037c1c1662240f6a (commit)
       via  b482f11d438ee84657690e0d1460a21c2814def8 (commit)
       via  a11d648980dc5bc9bb5b7dbf5228622a82d5d481 (commit)
       via  16cb9e92e5bf81086ad848e6b19e43bc9f74708a (commit)
       via  2672f9d7f697583cba3fef18fb75d5706e242c38 (commit)
       via  0b48213f4271d6314bb8f9a5b629695f2f30eb24 (commit)
       via  1c2329b02d9643f47dcf93aa7be9c31def4b2d91 (commit)
       via  f975945c2b26e640b8a73ab8cc73d5059bcf9f5f (commit)
       via  0ed2a1f5e810b37744c88b072e3883d1c5ba5845 (commit)
       via  7b27ff2fdeafa0acfb34257dbe4080bacacb4147 (commit)
       via  06baf06d21e5c808d0e0eed37f3a737dfe0f4e3b (commit)
       via  42e41883a4c8daad97201ad2a0d29443d9facc13 (commit)
       via  efdf8cc9641f16c6cf3e7d4d7aebcbf22350863b (commit)
       via  9ef4bad47377eefa83bc6a2fe5ae64e39707c266 (commit)
       via  d03a6206da9b74ff169dd71154992d80b966cd5d (commit)
       via  1e2c353b1a4f0895a0b6b887534dc70764637a68 (commit)
       via  0706bb18f98ace6aa2272833a9e3d61659a0cb8a (commit)
       via  fc381290bb1b1432513999c8fced120a316ada20 (commit)
       via  b85a24d6debdbea7bb5786a1470b5143ade3cfca (commit)
       via  f9c696fd03f177e6e2b4727126f124601f495f7c (commit)
       via  8df9ba7ec5c8a01b1a12ebab12c5b965441d0f21 (commit)
       via  a845188c7d3a7700301d5d649ad7685f72879d6d (commit)
       via  149cb5014932749cb0c13a2a8ae3ff18bfd4dc52 (commit)
       via  c06bc6422f8aba1ada7c2351f3a3ffc4c67576b1 (commit)
       via  39e1fbcbe95eb128dc9e6eb78df2ea2f0c68ff0f (commit)
       via  a3c922c2a1b8f24f0348480869904eccb2160079 (commit)
       via  9905247a481c7eb4db6d2cc38ea3f1041d66aa4b (commit)
       via  7ac45d00b6c2cabe3535ec31e901b2c6b0f6f191 (commit)
       via  a9779b67d652351c32486ffc005a01b465ec463e (commit)
      from  addb4a06b5e082c56f91a325565c0b688439a1de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ea7fa8d011afc6d2337aebb440c1bf1f4732b143
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 13 14:09:12 2018 -0300

    Bug 20144: DBIC Schema changes
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit fc30a2c82c487fdf6da354cccd86c29b2c1d4aee
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 13 14:07:37 2018 -0300

    Bug 20144: DBRev 17.12.00.015
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 53e46a58624f14f6528b6bd06c0eb39bd09b9e0f
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 16:32:26 2018 -0300

    Bug 20144: [sql_modes] Do not store 0000-00-00
    
    This patch needs to be linked with bug 20145.
    
    Fix for:
    Incorrect date value: '0000-00-00' for column 'dateexpiry'
    
    We cannot longer store 0000-00-00, but no need to.
    The tests must be kept for now as long as bug 20145 has a solution
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit fb16189e0bedb6c2c91d778ca842cfca2507018c
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 15:43:09 2018 -0300

    Bug 20144: [sql_modes] Fix GROUP BY clause in Virtualshelves search (DT)
    
    Fix for:
    'koha_kohadev.vs.shelfname' isn't in GROUP BY
    
    t/db_dependent/Utils/Datatables_Virtualshelves.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 3f69f6e1c8738564c30d613d245ea8af5f6b91fd
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 14:49:47 2018 -0300

    Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL 
if not passed
    
    Fix for:
    Incorrect integer value: '' for column 'numberlength'
    Incorrect integer value: '' for column 'weeklength'
    
    t/db_dependent/Serials/ReNewSubscription.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 410e3c81d59f27e4e21d4f55d45c9de74f6d80d9
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 14:47:43 2018 -0300

    Bug 20144: [sql_modes] Add default value for 
subscription_numberpatterns.description in tests
    
    Fix for:
    Field 'description' doesn't have a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 0fe8670547ec0fe3e55f8e0dbb77fbf07f141601
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 14:45:08 2018 -0300

    Bug 20144: [sql_modes] Fix search history tests
    
    Incorrect datetime value: '1374978877' for column 'time'
    
    Need to investigate this: Why did I put that value in the test?
    Does the feature correctly works?
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 129270cd4657f6b13b3890920cbd75cd83595187
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 14:39:32 2018 -0300

    Bug 20144: [sql_modes] Fix values when creating a sql report in tests
    
    For fix:
    Data too long for column 'report_area'
    Incorrect integer value: 'null' for column 'cache_expiry'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 44ca7c37acd2b5f16160c03d8772c1ff01f3990a
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 14:32:27 2018 -0300

    Bug 20144: [sql_modes] Set default value for opac_news.content in tests
    
    Fix for:
    Field 'content' doesn't have a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a93e49131d4d22c5bc2123f9a3626c36845d9e07
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 13:39:51 2018 -0300

    Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in 
GetItemsForInventory
    
    Fix for:
    DBD::mysql::st execute failed: Mixing of GROUP columns 
(MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP 
BY clause [for Statement 'SELECT COUNT(*)
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 8a0e21f0ecfd7e5bd135ad30e8955960b5d3549d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 13:36:42 2018 -0300

    Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests
    
    Fix for:
    Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is 
illegal if there is no GROUP BY clause
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit cf26f1f41f5d0d6ebedfe46b9405dc3b8fc71506
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 13:28:38 2018 -0300

    Bug 20144: [sql_modes] Set value for creator_batches.timestamp
    
    Fix for:
    Incorrect datetime value: 'now()' for column 'timestamp'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit b8f0a3fc40ce4aa64dec1c819a936d7397970ddf
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 13:27:32 2018 -0300

    Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests
    
    Fix for:
    Field 'datecreated' doesn't have a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ffae331219341978582bc1db7a03b2c6449b7227
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 12:51:19 2018 -0300

    Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp
    
    Not null
    
    Fix for:
    Incorrect datetime value: 'null' for column 'timestamp'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 21922eeac502d055ee5eaaf59da0ae8d251d37a3
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 12:34:34 2018 -0300

    Bug 20144: [sql_modes] Remove HAVING clause from GetTopIssues
    
    Fix for:
    'koha_kohadev.b.title' isn't in GROUP BY
    
    t/db_dependent/Circulation/GetTopIssues.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 29434b14549144589cc0663a25246914cb093d3d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 12:26:56 2018 -0300

    Bug 20144: [sql_modes] Remove 'Null' string values from GetHardDueDate.t
    
    Must be undef or correct integer value
    
    Fix for:
    Incorrect integer value: 'Null' for column 'enrolmentperiod'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 6f75f7bb9eec1325cf3c1527c571fbe392b478ad
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 12:15:02 2018 -0300

    Bug 20144: [sql_modes] Set default value for Itemtype fees in TestBuilder
    
    Fix for:
    Out of range value for column 'amount'
    
    t/db_dependent/Circulation/Chargelostitem.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 39b0b5909cb0bc271b85723eb32d02146649b3be
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 12:02:47 2018 -0300

    Bug 20144: [sql_modes] Fix GROUP BY clause in GetInvoices
    
    Need to be tested from the interface!
    
    Fix for:
    'koha_kohadev.aqinvoices.invoicenumber' isn't in GROUP BY
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 2e35da4f6b0e2c25ca1e6acb3e80f8b9d65cb658
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 11:54:18 2018 -0300

    Bug 20144: [sql_modes] Fix GROUP BY clause in GetBasketsInfosByBookseller
    
    This need to be tested from the interface!
    
    Fix for:
    'koha_kohadev.aqbasket.basketname' isn't in GROUP BY
    
    t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t
    
    We need this group by.
    We should not need to list all fields, from mysql 5.7 doc:
    https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html
    "The query is valid if name is a primary key of t or is a unique NOT NULL 
column. In such cases, MySQL recognizes that the selected column is 
functionally dependent on a grouping column. "
    
    However, MariaDB did not implemented yet:
    https://jira.mariadb.org/browse/MDEV-11588
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 406a480a780e67d3386e354907f8fac674257c17
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 11:08:02 2018 -0300

    Bug 20144: [sql_modes] Add default value for export_basket.description in 
tests
    
    Fix for:
    Field 'description' doesn't have a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 51ddaa78953b4751d193ebfec2efbf331c6f8502
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 11:00:31 2018 -0300

    Bug 20144: [sql_modes] Shorten values for virtualshelfshares.invitekey in 
tests
    
    It's a varchar(10)
    
    Fix for:
    Data too long for column 'invitekey'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 61679027b50baac783bd9f8914d5d31ac4364bb2
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 10:55:15 2018 -0300

    Bug 20144: [sql_modes] Set correct value for old_issues.issue_id in tests
    
    Fix for:
    Column 'issue_id' cannot be null
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit d43eb8b19c8b9fe51c5a6bde0a565fe363596e36
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 10:49:40 2018 -0300

    Bug 20144: [sql_modes] Shorten auth_header.authtypecode values in tests
    
    Fix for:
    Data too long for column 'authtypecode'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit db181fd8e15df0309898e3c6b62ed6446a68d526
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 10:48:49 2018 -0300

    Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests
    
    Fix for:
    Field 'marcxml' doesn't have a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a2292e83f13f499472e251995596ff04c263339d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 6 10:47:09 2018 -0300

    Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests
    
    Should call Koha::Biblio->new instead
    
    Fix for:
    Field 'datecreated' doesn't have a default value
    
    t/db_dependent/UsageStats.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 23018e15127c163ffb1559c3627cc261e846df07
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 19:13:07 2018 -0300

    Bug 20144: [sql_modes] Add default value for 
subscription_numberpatterns.description in tests
    
    Fix for:
    Field 'description' doesn't have a default value
    
    t/db_dependent/Serials.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit cbd566caf6e827e67c20d7d06de2e5bd7036dff5
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 19:10:34 2018 -0300

    Bug 20144: [sql_modes] Remove HAVING clause in GetBorrowersToExpunge
    
    Special attention needed here!
    
    Fix for:
    Non-grouping field 'currentissue' is used in HAVING clause
    
    t/db_dependent/Members.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 3755a38acfd4972d794bef8cb844e5474c3c4112
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 18:40:36 2018 -0300

    Bug 20144: [sql_modes] Set default value for 
marc_modification_template_actions
    
    Cannot be empty strings.
    
    Fix for:
    Data truncated for column 'conditional'
    Data truncated for column 'conditional_comparison'
    Incorrect integer value: '' for column 'conditional_regex'
    
    t/db_dependent/MarcModificationTemplates.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 666cbed5e17f8b644300c43091231554eaeb3eb0
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 18:26:05 2018 -0300

    Bug 20144: [sql_modes] Fix GROUP BY clause in GetLetters
    
    This subroutine is wrong and must be rewritten using
    Koha::Notice::Templates.
    Mainly because the DB structure is bad.
    Meanwhile we remove the branchcode from the SELECT to get correct
    results, it was not used by callers anyway.
    
    Fix for:
    'koha_kohadev.letter.module' isn't in GROUP BY
    
    t/db_dependent/Letters.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 2decad7b43e298524c0aea812462b73c7f088573
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 18:23:59 2018 -0300

    Bug 20144: [sql_modes] Correct quotes.timestamp values in tests
    
    Fix for:
    Incorrect datetime value: '0000-00-00 00:00:00' for column 'timestamp'
    
    t/db_dependent/Koha.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit e053ccb682402d57253471d8f07dcf906ea288c0
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 18:22:34 2018 -0300

    Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests
    
    When created without Koha::Biblio.
    
    Fix for:
    Field 'datecreated' doesn't have a default value
    
    t/db_dependent/Items.t
    
    TODO LATER - Use Koha::Biblio instead
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 294ea88614ab8683904dee5123d69c896a174f59
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 18:19:53 2018 -0300

    Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT
    
    Fix for:
    Field 'marcxml_old' doesn't have a default value
    
    t/db_dependent/ImportBatch.t
    
    Fixme - need to update existing DB?
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 6d439a5c5852db2c524c5ba027d0ce58c0d8d537
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 18:08:03 2018 -0300

    Bug 20144: [sql_modes] Remove HAVING clause in GetUpcomingDueIssues
    
    More attention needed here!
    
    Fix for:
    Non-grouping field 'days_until_due' is used in HAVING clause
    
    t/db_dependent/Circulation.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 7b51c8e443e32cdad241b032bca042a53c698769
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 18:02:12 2018 -0300

    Bug 20144: [sql_modes] Set issuingrules.no_auto_renewal_after to NULL in 
tests
    
    Fix for:
    Incorrect integer value: '' for column 'no_auto_renewal_after'
    
    FIXME - must we update values for existing installs?
    TODO - check if can be set to an empty string from the interface
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ae63d6e27156981a171540c0180a96f86c3fc184
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 17:48:03 2018 -0300

    Bug 20144: [sql_modes] Add default value for 
subscription_numberpatterns.description in tests
    
    Fix for:
    Field 'description' doesn't have a default value
    
    t/db_dependent/AdditionalField.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit ecc69f0ab24c926696ae1c537589801e0f41d9b5
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 17:38:32 2018 -0300

    Bug 20144: [sql_modes] Remove HAVING clause in GetLateOrders
    
    More attention needed here!
    
    Fix for:
    Non-grouping field 'quantity' is used in HAVING clause
    
    Having is useless, and certainly slower
    
    t/db_dependent/Acquisition.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit f854d16def40a97df326e356063bd931d03c3032
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 17:31:34 2018 -0300

    Bug 20144: [sql_modes] Shorten aqbudgets.budget_code
    
    Fix for:
    Data too long for column 'budget_code'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 5693d255d553e8670cb5da7a9f65e3e9a6a229bb
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 17:22:05 2018 -0300

    Bug 20144: [sql_modes] Set default value for Acccountline in TestBuilder
    
    Fix for:
    Data too long for column 'proccode'
    
    t/db_dependent/Accounts.t
    
    FIXME LATER - It's a varchar(4), must be integer!
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 2bb3392156e4314b948c39e4037c1c1662240f6a
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 17:17:11 2018 -0300

    Bug 20144: [sql_modes] Fix default value for statistics.itemnumber
    
    Must be an integer, not empty string
    
    Fix for:
    Incorrect integer value: '' for column 'itemnumber'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit b482f11d438ee84657690e0d1460a21c2814def8
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 16:24:56 2018 -0300

    Bug 20144: [sql_modes] Add a value for borrower_attribute_types.description 
in tests
    
    Fix for:
    Field 'description' doesn't have a default value
    
    t/db_dependent/Koha/Patron/Attribute/Types.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a11d648980dc5bc9bb5b7dbf5228622a82d5d481
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 16:21:43 2018 -0300

    Bug 20144: [sql_modes] Shorten items.barcode
    
    It's a varchar(20)
    
    Fix for:
    Data too long for column 'barcode'
    
    t/db_dependent/Koha/Items.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 16cb9e92e5bf81086ad848e6b19e43bc9f74708a
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 16:20:05 2018 -0300

    Bug 20144: [sql_modes] Correct quotes.timestamp values in tests
    
    Fix for:
    Incorrect datetime value: '0000-00-00 00:00:00' for column 'timestamp'
    
    t/db_dependent/Koha/GetDailyQuote.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 2672f9d7f697583cba3fef18fb75d5706e242c38
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 16:09:31 2018 -0300

    Bug 20144: [sql_modes] Add default values for export_format columns
    
    Fix for:
    Field 'field_separator' doesn't have a default value
    Field 'encoding' doesn't have a default value
    
    field_separator and subfield_separator are only used for MARC csv
    profiles, no need to specify a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 0b48213f4271d6314bb8f9a5b629695f2f30eb24
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 16:03:03 2018 -0300

    Bug 20144: [sql_modes] Shorten cities.city_zipcode
    
    It's a varchar(20)
    
    Fix for:
    Data too long for column 'city_zipcode'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 1c2329b02d9643f47dcf93aa7be9c31def4b2d91
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 15:51:03 2018 -0300

    Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests
    
    Fix for:
    Field 'marcxml' doesn't have a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit f975945c2b26e640b8a73ab8cc73d5059bcf9f5f
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 15:46:51 2018 -0300

    Bug 20144: [sql_modes] Set missinglist and recievedlist in 
subscriptionhistory
    
    Fix for:
    Field 'missinglist' doesn't have a default value
    
    t/db_dependent/Koha/Acquisition/Booksellers.t
    
    from mysql doc:
    BLOB, TEXT, GEOMETRY, and JSON columns cannot be assigned a default
     value.
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 0ed2a1f5e810b37744c88b072e3883d1c5ba5845
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 15:39:49 2018 -0300

    Bug 20144: [sql_modes] Fix date format in tests
    
    Fix for:
    Incorrect date value: '01-01-2013' for column 'startdate'
    Incorrect date value: '01-01-2016' for column 'budget_period_enddate'
    Incorrect date value: '30-11-2013' for column 'enddate'
    Incorrect date value: '31-12-2015' for column 'budget_period_enddate'
    Incorrect date value: '12-31-2015' for column 'budget_period_enddate'
    Incorrect date value: '01-01-2014' for column 'entrydate'
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 7b27ff2fdeafa0acfb34257dbe4080bacacb4147
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 15:36:27 2018 -0300

    Bug 20144: [sql_modes] Set default value for aqbasket.is_standing
    
    Fix for:
    Column 'is_standing' cannot be null
    
    t/db_dependent/Koha/Acquisition/Booksellers.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 06baf06d21e5c808d0e0eed37f3a737dfe0f4e3b
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 15:32:28 2018 -0300

    Bug 20144: [sql_modes] Fix datatype for aqbasket.authorisedby
    
    It's defined as a VARCHAR(10) in DB, but it is expecting a
    borrowernumber instead
    
    Fix for
    Data too long for column 'authorisedby'
    
    Must be a FK but first a borrowernumber
    Need to update kohastructure for the comment?
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 42e41883a4c8daad97201ad2a0d29443d9facc13
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 15:21:26 2018 -0300

    Bug 20144: [sql_modes] Set default value for Aqbookseller in TestBuilder
    
    Fix for:
    Out of range value for column 'tax_rate'
    
    t/db_dependent/Koha/Acquisition/Basket.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit efdf8cc9641f16c6cf3e7d4d7aebcbf22350863b
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 14:51:43 2018 -0300

    Bug 20144: [sql_modes] Fix generated value for account_offsets.amount
    
    Fix error:
    Out of range value for column 'amount'
    
    DBD::mysql::st execute failed: Out of range value for column 'amount' at
    row 1 [for Statement "INSERT INTO `account_offsets` ( `amount`,
    `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues:
    0=7925469795795194609664.000000, 1='10', 2='Manual Debit'] at
    /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
    
    7925469795795194609664.000000
    => Should be lower anyway
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 9ef4bad47377eefa83bc6a2fe5ae64e39707c266
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 14:41:48 2018 -0300

    Bug 20144: [sql_modes] Fix default value for statistics.amount
    
    Must be an integer, not empty string
    Fix for:
    Data truncated for column 'value'
    
    Found with
    t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit d03a6206da9b74ff169dd71154992d80b966cd5d
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 14:33:45 2018 -0300

    Bug 20144: [sql_modes] Set a default value for lowestPriority
    
    Fix for:
    Field 'lowestPriority' doesn't have a default value
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 1e2c353b1a4f0895a0b6b887534dc70764637a68
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Feb 5 14:28:31 2018 -0300

    Bug 20144: [sql_modes] Fix borrowers table structure
    
    surname, address and city can be NULL
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 0706bb18f98ace6aa2272833a9e3d61659a0cb8a
Author: Kyle M Hall <k...@bywatetsolutions.com>
Date:   Tue Jan 30 11:22:52 2018 -0500

    Bug 19530: Don't update the date arrived for closed transfers
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit fc381290bb1b1432513999c8fced120a316ada20
Author: Mark Tompsett <mtomp...@hotmail.com>
Date:   Wed Oct 25 21:28:10 2017 -0400

    Bug 19530: Added commentary for last test when prove -v
    
    Before patch, prove -v had no comment for the last test.
    After patch, it says something in line with second last test.
    
    Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
    
    Signed-off-by: Kyle M Hall <k...@bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit b85a24d6debdbea7bb5786a1470b5143ade3cfca
Author: Kyle M Hall <k...@bywatersolutions.com>
Date:   Wed Oct 25 14:24:18 2017 -0400

    Bug 19530: Prevent multiple transfers from existing for one item
    
    We have found multiple open branch transfers for a given item. While I'm 
not sure how it is happening at this point, it seems that it would make sense 
to cancel any existing branch transfers when initiating a new one.
    
    Test Plan:
    1) prove t/db_dependent/Circulation/transfers.t
    
    Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
    
    Signed-off-by: Josef Moravec <josef.mora...@gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit f9c696fd03f177e6e2b4727126f124601f495f7c
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Feb 13 13:34:12 2018 -0300

    Bug 19466: Restore original sentence to avoid additional translation
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 8df9ba7ec5c8a01b1a12ebab12c5b965441d0f21
Author: David Bourgault <david.bourga...@inlibro.com>
Date:   Thu Dec 21 10:20:48 2017 -0500

    Bug 19466: Warn about conflicting settings of autoMemberNum and 
BorrowerMandatoryField for cardnumber
    
    Changes the appearance of the cardnumber entry field in memberentrygen.tt
    The "Leave empty for autocalc" message has been moved to the hint div
    under the input field. If AutoMemberNum and BorrowerMandatoryField
    interfere with each other, the auto calc hint is replace by a warning
    telling the user that auto calc has been disabled.
    
    Cardnumber should now correctly appear as mandatory if marked as such
    in BorrowerMandatoryField.
    
    Test plan:
    0] Apply patch
    1} Disable AutoMemberNum, remove cardnumber from BorrowerMandatoryField
    2) Edit or create a patron, scroll down to cardnumber input field
        Hint is some form of "Cardnumber must be this long"
        Cardnumber input is not marked as required
        There is no mention of auto calc
    
    3> Enable AutoMemberNum
        Hint includes "Leave empty for auto calc" message
    
    4~ Add cardnumber to BorrowerMandatoryField
        Hint warns you that your sysprefs are conflicting.
        Cardnumber input is marked as required
    
    5: Disable AutoMemberNum
        Hint is some form of "Cardnumber must be this long"
        Cardnumber input is marked as required
    
    Signed-off-by: Claire Gravely <claire.grav...@bsz-bw.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer...@web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a845188c7d3a7700301d5d649ad7685f72879d6d
Author: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Date:   Fri Dec 22 10:08:07 2017 +0100

    Bug 19301: (QA follow-up) Add a few simple tests
    
    We removed tests from Reserves.t, but would be nice to test the new
    sub in IssuingRules.t too.
    Adding a subtest there.
    
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 149cb5014932749cb0c13a2a8ae3ff18bfd4dc52
Author: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Date:   Fri Dec 22 09:07:50 2017 +0100

    Bug 19301: (QA follow-up) Add POD, use statements and correct typo
    
    Add POD for new sub in Koha/IssuingRules.pm.
    Adding use Koha::IssuingRules to opac-detail and opac-MARCdetail.
    Adding use Koha::Items to opac-detail and opac-MARCdetail.
    Correct typo $items => $item in opac-MARCdetail.pl.
    
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit c06bc6422f8aba1ada7c2351f3a3ffc4c67576b1
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Tue Sep 12 14:04:08 2017 -0300

    Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed
    
    At this point the subroutine is not used anymore
    
    Signed-off-by: Alex Buckley <alexbuck...@catalyst.net.nz>
    
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 39e1fbcbe95eb128dc9e6eb78df2ea2f0c68ff0f
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Mon Sep 11 16:02:19 2017 -0300

    Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy
    
    Following the pattern introduced by bug 19300, we are going to move the
    OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy
    
    Test plan:
    Make sure the onshelfholds policy is correct when placing a hold
    
    Signed-off-by: Alex Buckley <alexbuck...@catalyst.net.nz>
    
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a3c922c2a1b8f24f0348480869904eccb2160079
Author: Alex Arnaud <alex.arn...@biblibre.com>
Date:   Fri Jan 12 09:51:45 2018 +0000

    Bug 4319: (QA follow-up) Rename hasItemswaitingOrInTransit to 
has_items_waiting_or_intransit
    
    and udate pod
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 9905247a481c7eb4db6d2cc38ea3f1041d66aa4b
Author: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Date:   Fri Dec 15 10:49:44 2017 +0100

    Bug 4319: (QA follow-up) Use ReservableItems in all scripts
    
    [1] Call CountItemsIssued or hasItemswaitingOrInTransit when needed only.
    [2] Add this logic to ISBD and MARC detail too, since they also use
        this include.
    
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    Confirming that Place hold now comes up if you have a waiting item and
    circulation rule == If any unavailable.
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit 7ac45d00b6c2cabe3535ec31e901b2c6b0f6f191
Author: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Date:   Fri Dec 15 10:09:29 2017 +0100

    Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest
    
    [1] For consistency going back to IsItemOnHoldAndFound in this sub.
        This call is used in the on_shelf_holds == 2 case too.
        The routine will be refactored quite soon.
        Adding the else branch for on_shelf_holds == 0 for more clarity.
    [2] Removing the test for found==F in reserves. In Koha F is only used
        when the hold is filled and moved to oldreserves.
    
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

commit a9779b67d652351c32486ffc005a01b465ec463e
Author: Alex Arnaud <alex.arn...@biblibre.com>
Date:   Tue Oct 3 14:50:36 2017 +0000

    Bug 4319: [OPAC] Allow holds on waiting/transit items
    
    Test plan:
    
     - Checkout an item
     - Place hold on this item,
     - Return the item
     - Make sure the hold is waiting (found W) and AllowOnShelfHolds is
       not to 'Allow'
     - Check that the button "Place hold" appears in opac detail page of
       the biblio
    
     - do the samewith items/reserves in transit
    
    Changes on C4::Reserves::IsAvailableForItemLevelRequest
    
    Make sure this tests pass:
      - t/db_dependent/Reserves.t
      - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
    
    Rebased - 2017-12-12 - Alex Arnaud
    
    Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit
    
    Signed-off-by: Jon Knight <j.p.kni...@lboro.ac.uk>
    
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |   17 +++--
 C4/Circulation.pm                                  |   22 +++---
 C4/ImportBatch.pm                                  |    6 +-
 C4/Items.pm                                        |    4 +-
 C4/Letters.pm                                      |    7 +-
 C4/MarcModificationTemplates.pm                    |    5 ++
 C4/Members.pm                                      |   35 +++++----
 C4/Reserves.pm                                     |   36 +++-------
 C4/Serials.pm                                      |    7 +-
 C4/Serials/Numberpattern.pm                        |    1 +
 C4/Stats.pm                                        |    4 +-
 C4/Utils/DataTables/VirtualShelves.pm              |    3 +-
 Koha.pm                                            |    2 +-
 Koha/Biblio.pm                                     |   22 ++++++
 Koha/IssuingRules.pm                               |   21 ++++++
 Koha/Schema/Result/Borrower.pm                     |   16 ++---
 Koha/Schema/Result/Deletedborrower.pm              |   16 ++---
 Koha/Schema/Result/ExportFormat.pm                 |   23 +++---
 Koha/Schema/Result/OldReserve.pm                   |   12 +++-
 Koha/Schema/Result/Reserve.pm                      |   12 +++-
 installer/data/mysql/kohastructure.sql             |   24 +++----
 installer/data/mysql/updatedatabase.pl             |   36 ++++++++++
 .../prog/en/modules/members/memberentrygen.tt      |   34 +++++----
 .../bootstrap/en/includes/opac-detail-sidebar.inc  |    2 +-
 opac/opac-ISBDdetail.pl                            |   12 ++--
 opac/opac-MARCdetail.pl                            |   10 ++-
 opac/opac-detail.pl                                |   18 +++--
 opac/opac-shelves.pl                               |    3 +-
 t/db_dependent/Acquisition.t                       |    4 +-
 t/db_dependent/Acquisition/GetBasketAsCSV.t        |    2 +
 .../Acquisition/GetBasketsInfosByBookseller.t      |    4 +-
 .../Acquisition/GetOrdersByBiblionumber.t          |    4 +-
 t/db_dependent/Acquisition/Invoices.t              |    4 +-
 t/db_dependent/Acquisition/NewOrder.t              |    4 +-
 t/db_dependent/Acquisition/OrderFromSubscription.t |   14 ++--
 t/db_dependent/Acquisition/OrderUsers.t            |    6 +-
 t/db_dependent/AdditionalField.t                   |    5 +-
 t/db_dependent/Bookseller.t                        |   31 ++++----
 t/db_dependent/Circulation.t                       |    4 +-
 t/db_dependent/Circulation/Chargelostitem.t        |    5 +-
 t/db_dependent/Circulation/GetHardDueDate.t        |   76 ++++++++++----------
 t/db_dependent/Circulation/OfflineOperation.t      |    9 ++-
 t/db_dependent/Circulation/transfers.t             |   19 ++++-
 t/db_dependent/Creators/Lib.t                      |   14 ++--
 .../Holds/DisallowHoldIfItemsAvailable.t           |   44 +++++++++++-
 t/db_dependent/Items.t                             |    2 +
 t/db_dependent/Items/GetItemsForInventory.t        |    2 +-
 t/db_dependent/Koha.t                              |    6 +-
 t/db_dependent/Koha/Acquisition/Booksellers.t      |   13 ++--
 t/db_dependent/Koha/Authorities.t                  |    4 +-
 t/db_dependent/Koha/Biblios.t                      |   42 ++++++++++-
 t/db_dependent/Koha/Cities.t                       |    4 +-
 t/db_dependent/Koha/CsvProfiles.t                  |    6 +-
 t/db_dependent/Koha/GetDailyQuote.t                |   17 +++--
 t/db_dependent/Koha/IssuingRules.t                 |   18 ++++-
 t/db_dependent/Koha/Items.t                        |    2 +-
 t/db_dependent/Koha/Patron/Attribute/Types.t       |    8 +--
 t/db_dependent/Koha/Patrons.t                      |    8 +--
 t/db_dependent/Letters.t                           |    3 +-
 .../Letters/GetLettersAvailableForALibrary.t       |   20 +++---
 t/db_dependent/Letters/TemplateToolkit.t           |    2 +-
 t/db_dependent/Reports/Guided.t                    |    8 +--
 t/db_dependent/Reserves.t                          |   26 +------
 t/db_dependent/Search/History.t                    |    2 +-
 t/db_dependent/Serials.t                           |    5 +-
 t/db_dependent/Serials/Numberpattern.t             |    4 +-
 t/db_dependent/UsageStats.t                        |   16 ++---
 t/db_dependent/Virtualshelves.t                    |    8 +--
 t/lib/TestBuilder.pm                               |   19 +++++
 69 files changed, 578 insertions(+), 326 deletions(-)


hooks/post-receive
-- 
main Koha release repository
_______________________________________________
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits

Reply via email to