This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1aae63606caeb389a40bd644b1f9e30917325573 (commit)
       via  16789351efd1f7dca88ed0797208ba5723922b62 (commit)
       via  2071fa4aca27f6748f32fd62037a203df2347141 (commit)
       via  669864f4b0cb16fc9a8566bffdeb42d7875fd8aa (commit)
       via  d5152dfcdf9ba63fd04d0dc15f34c851e5c85836 (commit)
       via  a57aea15a7f86e71bdfb6d6540aed18b2702b226 (commit)
       via  a9c730244768ea355004e821d5be35dc2e617840 (commit)
      from  f9572dd1acd9f39229d8cd864050a536b9c2815d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1aae63606caeb389a40bd644b1f9e30917325573
Author: Martin Renvoize <>
Date:   Fri Aug 16 12:17:42 2019 +0100

    Bug 23445: (RM follow-up) Add warning for unexpected lengthunit
    Discussions on this bug highlighted worries about behind the scenes
    fallbacks to 'days' as a lengthunit should the lengthunit be set to an
    unrecognised value. This patch adds a warning to the about page for any
    such occurrences so librarians may be made aware of and resolve the issue.
    Signed-off-by: Martin Renvoize <>

commit 16789351efd1f7dca88ed0797208ba5723922b62
Author: Katrin Fischer <>
Date:   Fri Aug 9 15:49:34 2019 +0000

    Bug 23445: Make loan period unit translatable fixing editing issue
    In the circulation rules, the loan period displayed in the table
    of circulation rules is not translatable, always displaying in English.
    This causes an issue when editing a circ rule with unit hours in any
    other language than English.
    When editing these rules, instead of hours, days will be preselected.
    To test:
    - Before applying the patch:
    - Install a translation
    - Activate and switch to the tranlation
    - Create a circulation rule using 'hours' as the unit
    - Edit the circulation rule
    - Verify that instead of 'hours' 'days' will be selected in the pull-down
    - Apply patch
    - Update po files (kshell, cd misc/translator, perl translate update 
    - Edit po file <langcode-staff..., search for Hours and translate line,
      make sure to also remove fuzzy, and that your translation matches the
      pull down values for your language
    - Reinstall translation
    - Repeat circ rule edit test
    - Verify the unit now shows up with your translation and editing works
    Signed-off-by: Owen Leonard <>
    Signed-off-by: Marcel de Rooy <>
    Signed-off-by: Martin Renvoize <>

commit 2071fa4aca27f6748f32fd62037a203df2347141
Author: Aleisha Amohia <>
Date:   Mon Apr 29 01:25:46 2019 +0000

    Bug 22799: Avoiding batch item modification case sensitivity when entering 
    Note: this fixes the bug that is present right now where batch item
    modification barcode matching is case sensitive, but if Koha barcodes
    ever do become case sensitive, this patch will need to be removed.
    To test:
    1) Make/use an item with a barcode with letters in it. For testing
    purposes, I'll be using an item with the barcode 'abcde'.
    2) Go to Tools -> Batch item modification and enter this barcode in the
    barcode list text input field, but change the case of one or some
    letters. (i.e. enter the barcode in the field as 'abCDE')
    3) Click Continue
    4) Notice that the next page shows an error 'the following barcodes were
    not found', but the item still shows underneath (was correctly fetched from 
    5) Create a text file and put the changed-case barcode in it (i.e. put
    the barcode 'abCDE' in the text file)
    6) Go back to batch item modification and upload the
    text file as a barcode file
    7) Notice same error as in Step 4
    8) Apply patch and refresh page
    9) Run through steps 1 to 6. There should no longer be an error and the
    barcodes should be found as expected.
    Sponsored-by: South Taranaki District Council
    Signed-off-by: Maryse Simard <>
    Signed-off-by: Kyle Hall <>
    Signed-off-by: Donna Bachowski <>
    Signed-off-by: Marcel de Rooy <>
    Signed-off-by: Martin Renvoize <>

commit 669864f4b0cb16fc9a8566bffdeb42d7875fd8aa
Author: Fridolin Somers <>
Date:   Thu May 2 14:20:45 2019 +0200

    Bug 22830: correct for loop in value_builder/ 
    In value_builder/ value_builder gets search results
    and runs a for loog with $i index. This loop is limiter with number of
    results par page, it should also be limited by number of results if
    lower that number of results par page.
    Same in cataloguing/value_builder/
    Test plan :
    1) configure framework to use value builder
    2) use value builder
    3) perform a search with number of results lower than number of results
       per page
    4) check number of records diplayed is OK
    5) perform a search with number of results upper than number of results
       per page and check number of results is OK
    6) you see number of results par page records and pagination link
    Signed-off-by: Owen Leonard <>
    Signed-off-by: Marcel de Rooy <>
    Signed-off-by: Martin Renvoize <>

commit d5152dfcdf9ba63fd04d0dc15f34c851e5c85836
Author: Katrin Fischer <>
Date:   Fri Aug 9 16:02:54 2019 +0000

    Bug 23446: Fix display issue in serials navigation
    The serial navigation shows a little stangely on the
    serial subscription detail page and other pages that show
    information about a specific subscription with one of the menu items
    having a different display height than the other items.
    To test:
    - Go to the serials module
    - Add or search for an existing subscription
    - Go to the subscription detail page
    - Verify the display issue in the navigation on the left
    - Apply patch
    - Check again from different pages in the serials module
    - Verify display is improved
    Signed-off-by: Owen Leonard <>
    Signed-off-by: Marcel de Rooy <>
    Signed-off-by: Martin Renvoize <>

commit a57aea15a7f86e71bdfb6d6540aed18b2702b226
Author: Owen Leonard <>
Date:   Thu Aug 15 13:46:35 2019 +0000

    Bug 23455: Patron card printing from Patron lists is broken
    This patch makes a few corrections to the process of printing patron
    cards from the patron lists page. These changes are necessitated by Bug
    20650: Changes to the markup in patroncards/ were not reflected
    in the JavaScript in patron_lists/
    Also fixed: A missing quotation mark, a missing semicolon, and
    incorrect template variable filter.
    To test, apply the patch and go to Tools -> Patron lists.
     - Click the "Actions" menu corresponding to a patron list.
     - Select "Print patron cards."
     - In the "Print patron cards" modal, click the "Export" button.
     - The modal should reload with a link to download a patron card PDF.
       The link should work correctly.
    Signed-off-by: Katrin Fischer <>
    Signed-off-by: Marcel de Rooy <>
    Signed-off-by: Martin Renvoize <>

commit a9c730244768ea355004e821d5be35dc2e617840
Author: Jonathan Druart <>
Date:   Sun Aug 4 12:48:07 2019 -0500

    Bug 23242: Fix insert of Z3950 servers with strict SQL modes
    If strict SQL modes are set, the insertion of a new Z3950 server can
    DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: ''
    for column 'checked' at row 1 at
    /home/vagrant/kohaclone/admin/ line 82
    Using Koha::Z3950Servers fixes the issue (handled from
    Test plan:
    - Turn the strict SQL modes on (config strict_sql_modes)
    - Create a new Z3950 server filling only the mandatory fields.
    => Without this patch you will get the failure, with this patch applied
    the server will be inserted sucessfully
    - Delete it
    => No regression should be found
    - Search for servers
    => No regression should be found (the search is a start-with, LIKE 
    Signed-off-by: Katrin Fischer <>
    Signed-off-by: Marcel de Rooy <>
    Signed-off-by: Martin Renvoize <>


Summary of changes:                                             |   16 ++++++++++++++++
 admin/                                |   18 +++++++++---------
 cataloguing/value_builder/  |    2 +-
 cataloguing/value_builder/       |    2 +-
 .../intranet-tmpl/prog/en/includes/  |    6 ++----
 koha-tmpl/intranet-tmpl/prog/en/modules/     |   17 ++++++++++++++++-
 .../prog/en/modules/admin/             |    8 +++++++-
 .../prog/en/modules/patron_lists/            |    6 +++---
 .../prog/en/modules/patroncards/             |    4 +++-
 tools/                                    |   12 ++++++++++--
 10 files changed, 68 insertions(+), 23 deletions(-)

main Koha release repository
koha-commits mailing list

Reply via email to