This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  accba6b13a37b0b5a68c7955161e29d3ca1e24da (commit)
      from  105e3c9ce04d2958d9e0749c579f73fece94d641 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit accba6b13a37b0b5a68c7955161e29d3ca1e24da
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date:   Sun Aug 4 12:48:07 2019 -0500

    Bug 23242: Fix insert of Z3950 servers with strict SQL modes
    
    If strict SQL modes are set, the insertion of a new Z3950 server can
    fail.
    
    DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: ''
    for column 'checked' at row 1 at
    /home/vagrant/kohaclone/admin/z3950servers.pl line 82
    
    Using Koha::Z3950Servers fixes the issue (handled from
    Koha::Object->store)
    
    Test plan:
    - Turn the strict SQL modes on (config strict_sql_modes)
    - Create a new Z3950 server filling only the mandatory fields.
    => Without this patch you will get the failure, with this patch applied
    the server will be inserted sucessfully
    - Delete it
    => No regression should be found
    - Search for servers
    => No regression should be found (the search is a start-with, LIKE 
"$pattern%")
    
    Signed-off-by: Katrin Fischer <katrin.fischer...@web.de>
    Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
    (cherry picked from commit a9c730244768ea355004e821d5be35dc2e617840)
    Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
    (cherry picked from commit 164893acfe89fbf1156ad8a93bee28771ba370d8)
    
    Signed-off-by: Lucas Gass <lu...@bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 admin/z3950servers.pl |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository
_______________________________________________
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits

Reply via email to