This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  4bc565692778cf8521e0e8ce7ea841babe83d918 (commit)
       via  ca186563c1cd8df18606cd48cffed47633674d5f (commit)
       via  3a8c118931149173d3e1afc0255243c458cdadc8 (commit)
       via  93ad4e2d52290607b0fbd023e41e1ccc42c950c4 (commit)
       via  048f154e772bed09b50cb6343e89adb4ff4d78f6 (commit)
       via  0656ff9a99d733b483e6b800d8b58554435109b5 (commit)
      from  73e40ba8044a05e2bf13f1b8492fe1cf2c46d742 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4bc565692778cf8521e0e8ce7ea841babe83d918
Author: Aleisha Amohia <[email protected]>
Date:   Fri Jul 31 00:39:34 2020 +1200

    [19.11.x] Bug 25850: Tests fail when useDaysMode is not set to Calendar
    
    t/db_dependent/Calendar.t tests fail
    
    This patch is needed as long as useDaysMode is checked in
    Koha::Calendar->_init
    
    Signed-off-by: Aleisha Amohia <[email protected]>

commit ca186563c1cd8df18606cd48cffed47633674d5f
Author: Martin Renvoize <[email protected]>
Date:   Fri Jun 26 16:24:00 2020 +0100

    Bug 25850: Add tests for weekday holidays
    
    Signed-off-by: Martin Renvoize <[email protected]>
    Signed-off-by: Nick Clemens <[email protected]>
    Signed-off-by: Martin Renvoize <[email protected]>
    (cherry picked from commit 4ed4e468d2ceaf4502b817feb791656d5a159fa5)
    
    Signed-off-by: Lucas Gass <[email protected]>
    (cherry picked from commit e6522ea63c6258b162c23731d2d3ff3950808152)
    
    Signed-off-by: Aleisha Amohia <[email protected]>

commit 3a8c118931149173d3e1afc0255243c458cdadc8
Author: Nick Clemens <[email protected]>
Date:   Tue Jul 7 12:05:42 2020 +0000

    Bug 25850: (QA follow-up) use dt_from_string
    
    Signed-off-by: Nick Clemens <[email protected]>
    Signed-off-by: Martin Renvoize <[email protected]>
    (cherry picked from commit 92970a9abad312a07d9efba46cc57b27469a0509)
    
    Signed-off-by: Lucas Gass <[email protected]>
    (cherry picked from commit f63c82a30f2e9455ce07085f3030d5160658c9f7)
    
    Signed-off-by: Aleisha Amohia <[email protected]>

commit 93ad4e2d52290607b0fbd023e41e1ccc42c950c4
Author: Martin Renvoize <[email protected]>
Date:   Mon Jun 29 09:54:58 2020 +0100

    Bug 25850: (QA follow-up) Match logic in is_holiday
    
    Signed-off-by: Nick Clemens <[email protected]>
    Signed-off-by: Martin Renvoize <[email protected]>
    (cherry picked from commit afd88e1d21a5cb5f2198c058144065b64098c124)
    
    Signed-off-by: Lucas Gass <[email protected]>
    (cherry picked from commit 4c0d7b14bebcedb802488ee1fb200a2c7513ca91)
    
    Signed-off-by: Aleisha Amohia <[email protected]>

commit 048f154e772bed09b50cb6343e89adb4ff4d78f6
Author: Andreas Jonsson <[email protected]>
Date:   Tue Jun 23 15:57:29 2020 +0200

    Bug 25850: Adapt day of week in Koha::Calendar::get_push_amt to 0..6 with 0 
being Sunday.
    
    1. Go to tools -> calendar and make sure Sundays are holidays by adding
       a holiday on a Sunday and selecting "Holiday repeated every same day
       of the week" and "Copy to all libraries" and save.
    2. Go to administration -> system preferences and select "Use the
       calendar to push the due date to the next open matching weekday
       for weekly loan periods, or the next open day otherwise" for the
       system preference "useDaysMode" and save the system preferences.
    3. Put the below code in a file name test.pl and execute it using
       the command "sudo koha-shell -c 'perl test.pl' kohadev"
    
       use Koha::Calendar;
    
       my $calendar = Koha::Calendar->new( branchcode => 'CPL' );
       $dt = DateTime->new(
           year       => 2020,
           month      => 06,
           day        => 21
       );
    
       print "This is a sunday: " .
       $dt->day_of_week . "\n";
    
       my $ndt = $calendar->next_open_days($dt, 0);
    
       print "This is a monday: " .
       $ndt->day_of_week . "\n";
    
    4. Without the patch applied, this script
       will freeze after printing "This is a
       sunday ...".  Abort using ctrl-c.
    5. Apply patch and run the script again.
       The test script will now complete.
    
    Signed-off-by: Martin Renvoize <[email protected]>
    Signed-off-by: Nick Clemens <[email protected]>
    Signed-off-by: Martin Renvoize <[email protected]>
    (cherry picked from commit 25127f422821756b030b8f377b3e112b907be5eb)
    
    Signed-off-by: Lucas Gass <[email protected]>
    (cherry picked from commit 238b2af84fe8efe8a740758a774f3587717ffb2b)
    
    Signed-off-by: Aleisha Amohia <[email protected]>

commit 0656ff9a99d733b483e6b800d8b58554435109b5
Author: Martin Renvoize <[email protected]>
Date:   Fri Jun 26 16:52:50 2020 +0100

    Bug 25850: Regression Test
    
    This patch adds a unit test to test for an infinite loop as highlighted
    by the bug.
    
    Test plan
    1/ Run the test before applying the fix
    2/ The test should fail for 'Sundays'
    3/ Apply the subsquent patch
    4/ Re-run the test
    5/ It should now pass
    
    Signed-off-by: Martin Renvoize <[email protected]>
    Signed-off-by: Nick Clemens <[email protected]>
    Signed-off-by: Martin Renvoize <[email protected]>
    (cherry picked from commit 95c8d19530e8bef20e02be0b74d7927764bf7ed1)
    
    Signed-off-by: Lucas Gass <[email protected]>
    (cherry picked from commit f5f3269e25169e295fa495dc6b38114edcb767a6)
    
    Signed-off-by: Aleisha Amohia <[email protected]>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Calendar.pm          |   9 +++-
 t/db_dependent/Calendar.t | 102 +++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 109 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
_______________________________________________
koha-commits mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits

Reply via email to