This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via db5ae24f887bd10f8b3c5cf3e0cc65e3ae3178d1 (commit)
via 63802370efc001600524314e222d619e28da7ea8 (commit)
from e1df84e9ecae7d48e91f2e08333b664de39ce912 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit db5ae24f887bd10f8b3c5cf3e0cc65e3ae3178d1
Author: Nick Clemens <[email protected]>
Date: Fri Jun 12 10:51:36 2020 +0000
Bug 25724: Do not call ModReserveStatus when completing transfer
I can not see how this code is useful here. It checks for a reserve with
priority 0 and found = NULL
That is not a status that should occur when filling a transfer. Either the
found is 'T' if we are transferring due
to the hold, or the hold was placed after the transfer was initiated, and
so the priority is not 0
Additional, AddReturn checks for reserves later and asks the staff to
confirm waiting status.
ModReserveStatus also calls CartToShelf regardless of what happens here.
To test:
1 - Set UpdateItemLocationOnCheckin to:
_ALL_: CART
2 - SetAutomaticItemReturn = Do
3 - Check an item in at a different branch than it's homebranch to create a
transfer
4 - Check the item in at it's homebranch
5 - View the item details page
6 - Item is not in CART location
7 - Apply patch
8 - Repeat
9 - Item is in CART location after completion of transfer
Signed-off-by: Andrew Fuerste-Henry <[email protected]>
Signed-off-by: Jason Robb <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
(cherry picked from commit e025cd76437b212746717ad54b5da22e410bbe8f)
Signed-off-by: Lucas Gass <[email protected]>
(cherry picked from commit 51cd56ddb37dbb3c92105d948b8a83b98ad6bcfb)
Signed-off-by: Aleisha Amohia <[email protected]>
commit 63802370efc001600524314e222d619e28da7ea8
Author: Nick Clemens <[email protected]>
Date: Fri Jun 12 11:11:26 2020 +0000
Bug 25724: Unit tests
Signed-off-by: Andrew Fuerste-Henry <[email protected]>
Signed-off-by: Jason Robb <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
(cherry picked from commit 028e9a07db625845482eff1b550a9bbe86ec6fbc)
Signed-off-by: Lucas Gass <[email protected]>
(cherry picked from commit bc1e7669bd2b1abccba7b1975b66adac0de550d2)
Signed-off-by: Aleisha Amohia <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 2 --
t/db_dependent/Circulation/issue.t | 12 +++++++++++-
2 files changed, 11 insertions(+), 3 deletions(-)
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
